Skip to content

Regions names for parameterized tests #1301

Closed
#1393
Closed
Regions names for parameterized tests#1301
#1393
Assignees
EgorkaKulikov
Labels
comp-summariesSomething related to the method names, code comments and display names generationctg-bugIssue is a bugstatus-verifiedBug fix is verified
Milestone
2022.12 Release

Description

@alisevych
alisevych
opened on Nov 3, 2022

Description

Some tests generated for ArraysQuickSort.sort in Parameterized mode are presented as regular tests.
They are put in to region
///region Tests for method sort(int[], int, int, int[], int, int) that cannot be presented as parameterized
Now there are 2 types of such tests:

To Reproduce

  1. Install latest build from main into IDEA 2022.2.3
  2. Check File -> Settings are default: 95% Symbolic execution
  3. Open UTBotJava project
  4. Generate tests for ArrayQuickSort with JUnit5 and Parameterized on.

Expected behavior

Regions in the generated tests are supposed to be similar to the ones generated with parameterization off.

Actual behavior

///region Tests for method sort(int[], int, int, int[], int, int) that cannot be presented as parameterized

Regions in generated tests, that cannot be presented as parameterized, do not contain information about which suite they belong to.
Fuzzing / Symbolic, Successful / Explicitly thrown exceptions / ...

Visual proofs (screenshots, logs, images)

Regions for parameterized tests:
image

Regions for regular tests:
image

Environment

IntelliJ IDEA

Activity

  1. alisevych
    added
    ctg-bugIssue is a bug
    on Nov 3, 2022
  2. alisevych
    assigned
    EgorkaKulikov
    on Nov 3, 2022
  3. korifey
    added this to UTBot Javaon Nov 3, 2022
  4. korifey
    moved this to Todo in UTBot Javaon Nov 3, 2022

  5. alisevych commented on Nov 3, 2022

    @alisevych
    alisevych
    on Nov 3, 2022
    MemberAuthor

    @korifey @amandelpie @EgorkaKulikov
    Could you please check the expected and actual result? What would be the correct way to name these suites?

  6. alisevych
    added this to the 2022.12 Release milestone on Nov 8, 2022
  7. alisevych
    added
    comp-summariesSomething related to the method names, code comments and display names generation
    on Nov 8, 2022
  8. EgorkaKulikov
    added a commit that references this issue on Nov 11, 2022

    Improve documentation for regions in parametrized tests #1301 (#1340)

    b55fef0

  9. amandelpie commented on Nov 14, 2022

    @amandelpie
    amandelpie
    on Nov 14, 2022
    Collaborator

    @alisevych could we say now that we are satisfied for today with the existing master?

  10. alisevych commented on Nov 17, 2022

    @alisevych
    alisevych
    on Nov 17, 2022
    MemberAuthor

    @alisevych could we say now that we are satisfied for today with the existing master?

    As for regions for parameterized tests - they are readable:

        ///region Test suites for executable org.utbot.examples.algorithms.Sort.quickSort
    ///region Parameterized test for method quickSort(long[], int, int)
    ///endregion
    ///region FUZZER: Tests for method quickSort(long[], int, int)
    ///endregion
    ///endregion

    Can we also leave information that these tests cannot be presented as parameterized - as it was done before?

  11. EgorkaKulikov
    added a commit that references this issue on Nov 18, 2022

    Fixed the region names #1301 (#1393)

    e87b09f
  12. EgorkaKulikov
    closed this as completedin #1393on Nov 18, 2022
  13. Repository owner moved this from Todo to Done in UTBot Javaon Nov 18, 2022
  14. alisevych
    added
    status-verifiedBug fix is verified
    on Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

comp-summariesSomething related to the method names, code comments and display names generationctg-bugIssue is a bugstatus-verifiedBug fix is verified

Type

No type

Projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions