Skip to content

AbstractTestCaseGeneratorTest.kt and SummaryTestCaseGeneratorTest.kt contains duplicated methods #382

Closed

Description

@amandelpie

This class and its inheritor need to be refactored because they have duplicated methods:

SummaryTestCaseGeneratorTest has

  • List<UtExecution>.checkMatchersWithTextSummary
  • List<UtExecution>.checkMatchersWithMethodNames
  • List<UtExecution>.checkMatchersWithDisplayNames

used for tests in utbot.summary.tests module

and AbstractTestCaseGeneratorTest has

  • List<UtValueExecution<*>>.checkNameMatchers
  • List<UtValueExecution<*>>.checkDisplayNameMatchers
  • List<UtValueExecution<*>>.checkCommentsForBasicErrors
  • List<UtValueExecution<*>>.checkNamesForBasicErrors

used in internalCheck method

It uses some copy-pasted logic which should be refactored to the common methods.

Probably it uses in different places, environments and with different hacks, but checking logic should be common.

Activity

  1. added
    ctg-refactoringIssue related to refactoring process
    comp-summariesSomething related to the method names, code comments and display names generation
    on Jul 4, 2022
  2. self-assigned this
    on Jul 4, 2022
  3. amandelpie commented on Jan 18, 2023

    @amandelpie
    CollaboratorAuthor

    It could be easily fixed but requires 1-2 days to fix and re-run all summaries tests to be sure that logic is not erased

  4. self-assigned this
    on Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

comp-summariesSomething related to the method names, code comments and display names generationctg-refactoringIssue related to refactoring process

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions