Repository navigation
fix(datetime): use date-specific offsets for naive call filters - #30
Draft
Kayvan-Zahiri wants to merge 1 commit into
Draft
Kayvan-Zahiri wants to merge 1 commit into
Kayvan-Zahiri wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Naive datetimes in call-history filters receive today's local UTC offset, shifting historical/future filter boundaries across DST seasons. In Los Angeles during PDT, January noon is sent with
-07:00rather than-08:00.Use the input datetime's
astimezone()conversion to apply local rules for its own date, including ambiguous fall-back folds. Explicitly aware datetimes retain existing behavior.Fixes #29. This is a tested proof of concept under the README contribution policy: the change belongs in the Fern-generated runtime and needs porting into generation before durable merge.
Validation:
calls.listHTTPX MockTransport cases cover four created/updated filters, winter/summer, both DST folds, explicit UTC/positive-offset datetimes, and microseconds. Before: 24 failed, 32 passed. After: all 56 pass.