This repository was archived by the owner on Jul 29, 2026. It is now read-only.
Repository navigation
This repository was archived by the owner on Jul 29, 2026. It is now read-only.
Login and Signup form as directive #552
Description
Is there an interest to write the login and the signup form in directives. I see following advantages:
- the login and signup controllers isn't anymore bound with a view;
- the two forms could be easily moved to another place (on the landing page or on a modal view);
Should I propose a PR?
Activity
18601673727 commentedon Sep 16, 2014
Why not we integrate with satellizer(https://github.com/sahat/satellizer), so lets stop from rebuilding wheels.
thomporter commentedon Sep 16, 2014
I would hate to see support for PassportJS dropped. There are just too
many providers they support http://passportjs.org/guide/providers/.
kingcody commentedon Sep 16, 2014
I agree with @thomporter.
JaKXz commentedon Sep 25, 2014
I too agree with @thomporter. Having directives that use the
$scopeof whatever page they're on for the reusable components would be very nice though.kingcody commentedon Sep 26, 2014
@remicastaing do you have a branch for this? I have a working setup that I'd be happy to share.
remicastaing commentedon Sep 26, 2014
@kingcody, I don't have generator branch, just angular-fullstack app branch with login, signup directive.-
Rémi
On Fri, Sep 26, 2014 at 2:28 PM, Cody Mize notifications@github.com
wrote:
remicastaing commentedon Sep 26, 2014
@kingcody, you will find a branch for this here: https://github.com/remicastaing/angular-fullstack/tree/login_signup_navbar_directive
JaKXz commentedon Sep 27, 2014
PRs for this and #457 would be awesome. Does anyone else think that all the
components/should be directives (with the exception of the modal service)?kingcody commentedon Sep 27, 2014
I'd like to share my opinion and hear what others have to say on the matter.
/appThis is where the "pages" of the website live; everything that is specific to a particular page goes (somewhere) in here.
/componentsAny thing that is not specific to a page and/or is reusable goes here.
That being said, my
componentsfolder is typically the larger of the two as I attempt to make most things modular or at least initially plan to reuse them. So I find myself regrouping/reorganizing my component folder quite often when I build a project.One thing that I seem to do a majority of the time is create a user folder in components and move the user $resource to there. I also create directives (in there) for the user login form and signup form. Those two directives simply manage the form, the user's input and form validation.
I realize that it may seem over the top to some and it very well may be for different setups, but what that allows me to do is use the same form on the signup directive as well as the edit user directive (sans styling). I also use the same "auth" form in the login directive as well as my "action" auth directive (I use that for specific actions that require auth on the spot before completion).
I'm not suggesting that we take such an intricate approach here, but I would like to see the components that are used become more modular and possibly be grouped better.
Another benefit is that it is much easier to write unit tests for a small modular piece than a large monolithic app; and when something does break ( and it probably will 😄 ) it's not such an ordeal to debug the issue.
Anyways, those are my thoughts.
remicastaing commentedon Sep 27, 2014
What I have already done is based on PR #444 (replacing ngCookie by ngStorage).