Repository navigation
fix(@angular/build): only generate shallow preload links for initial files - #27581
Merged
Merged
Conversation
alan-agius4
approved these changes
May 2, 2024
alan-agius4
left a comment
Collaborator
There was a problem hiding this comment.
NIT: the scope should be @angular/build.
alan-agius4
reviewed
May 2, 2024
clydin
force-pushed
the
application/shallow-preloads
branch
2 times, most recently
from
May 2, 2024 15:44
47c73ca to
f2ae94f
Compare
…files To remove the potential for a large amount of modulepreload link elements being added to the generating `index.html` for an application, the number of elements is now limited to three. Also, only first-level initial scripts will be added. Previously all initial scripts regardless of depth were eligible for preloading. The preload generation can still be fully disabled via the `index.preloadInitial` option within the build options.
clydin
force-pushed
the
application/shallow-preloads
branch
from
May 2, 2024 15:50
f2ae94f to
131fdb5
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To remove the potential for a large amount of modulepreload link elements being added to the generating
index.htmlfor an application, the number of elements is now limited to five. Also, only first-level initial scripts will be added. Previously all initial scripts regardless of depth were eligible for preloading. The preload generation can still be fully disabled via theindex.preloadInitialoption within the build options.