Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions packages/angular/build/src/builders/library/options.ts
Original file line number Diff line number Diff line change
Expand Up @@ -105,17 +105,6 @@ export async function normalizeLibraryOptions(
{ glob: 'README.md', input: projectRoot, output: '.' },
];

for (const entryPoint of entryPoints.values()) {
if (entryPoint.isPrimary) {
continue;
}
defaultAssets.push({
glob: 'README.md',
input: path.posix.dirname(entryPoint.entryFilePath),
output: entryPoint.name,
});
}

const assets = normalizeAssetPatterns(
[...defaultAssets, ...(rawAssets ?? [])],
workspaceRoot,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,5 +53,76 @@ describeLibraryBuilder(executeLibraryBuilder, LIBRARY_BUILDER_INFO, (harness) =>

expect(harness.readFile('dist/lib/docs/README.md')).toBe('# Library Docs');
});

it('should not copy root README.md into secondary entry point output when secondary entry point is in projectRoot', async () => {
await harness.writeFiles({
'projects/lib/README.md': '# Root Library README',
'projects/lib/testing.ts': 'export const TESTING = true;',
});

await harness.modifyFile('projects/lib/package.json', (content) => {
const pkg = JSON.parse(content);
pkg.exports = {
'.': './src/public-api.ts',
'./testing': './testing.ts',
};

return JSON.stringify(pkg, null, 2);
});

const { result } = await harness.executeOnce();
expect(result?.success).toBeTrue();

expect(harness.readFile('dist/lib/README.md')).toBe('# Root Library README');
expect(harness.hasFile('dist/lib/testing/README.md')).toBeFalse();
});

it('should not copy README.md into secondary entry point output when sharing directory with primary entry point', async () => {
await harness.writeFiles({
'projects/lib/README.md': '# Root Library README',
'projects/lib/src/README.md': '# Src README',
'projects/lib/src/testing.ts': 'export const TESTING = true;',
});

await harness.modifyFile('projects/lib/package.json', (content) => {
const pkg = JSON.parse(content);
pkg.exports = {
'.': './src/public-api.ts',
'./testing': './src/testing.ts',
};

return JSON.stringify(pkg, null, 2);
});

const { result } = await harness.executeOnce();
expect(result?.success).toBeTrue();

expect(harness.readFile('dist/lib/README.md')).toBe('# Root Library README');
expect(harness.hasFile('dist/lib/testing/README.md')).toBeFalse();
});

it('should only copy the root README.md by default and not secondary entry point README.md files', async () => {
await harness.writeFiles({
'projects/lib/README.md': '# Root Library README',
'projects/lib/testing/README.md': '# Testing Entry Point README',
'projects/lib/testing/public-api.ts': 'export const TESTING = true;',
});

await harness.modifyFile('projects/lib/package.json', (content) => {
const pkg = JSON.parse(content);
pkg.exports = {
'.': './src/public-api.ts',
'./testing': './testing/public-api.ts',
};

return JSON.stringify(pkg, null, 2);
});

const { result } = await harness.executeOnce();
expect(result?.success).toBeTrue();

expect(harness.readFile('dist/lib/README.md')).toBe('# Root Library README');
expect(harness.hasFile('dist/lib/testing/README.md')).toBeFalse();
});
});
});
Loading