Repository navigation
perf(@angular/build): cache pre-declaration transformed SourceFiles during AoT emit - #34425
Open
alan-agius4 wants to merge 3 commits into
Open
alan-agius4 wants to merge 3 commits into
alan-agius4 wants to merge 3 commits into
Conversation
…uring AoT emit Cache transformed `SourceFile` ASTs in a `Map` in `ensurePreDeclarationTransformers` instead of only tracking visited files in a `Set`. When `.d.ts`-only emit runs prior to `.js` emit (such as for transitive importers during incremental library builds), the subsequent `.js` emit now reuses the cached transformed `SourceFile` instead of executing `before` transformers a second time.
…Files during AoT emit
alan-agius4
marked this pull request as ready for review
October 20, 2026 12:44
There was a problem hiding this comment.
Code Review
This pull request exports and refactors the ensurePreDeclarationTransformers function in aot-compilation.ts to properly cache and reuse pre-transformed source files. The implementation now combines all before-transformers into a single transformer and utilizes a map to cache the transformed ASTs during the declaration emit phase, preventing redundant executions when subsequently emitting JavaScript. Comprehensive unit tests have also been added in angular-compilation_spec.ts to verify this behavior. There are no review comments, so I have no feedback to provide.
…Files during AoT emit
dgp1130
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BuilderProgram.emitNextAffectedFileemits.d.ts-only (emitOnly = Dts) for an affected transitive importer, TypeScript skipstransformers.beforeand runstransformers.afterDeclarations.ensurePreDeclarationTransformersrunsbeforetransformers insideafterDeclarationsto populate Angular'sdtsTransforms, and caches the transformedts.SourceFileinpreTransformedSourceFilesonly for those.d.ts-first files (deleting the entry immediately when consumed by a subsequent.jsemit)..js-first / combined.js+.d.tsemits, tracksseenSourceFilesvia aSet<ts.SourceFile>without retaining transformedSourceFileASTs in memory across the emit loop.Benchmark Results
main