Skip to content

fix(@angular/build): name the provider packages in the unit-test browsers error #34442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
clydin merged 2 commits into from
Oct 21, 2026
Merged

fix(@angular/build): name the provider packages in the unit-test browsers error #34442

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5117654
fix(@angular/build): name the provider packages in the unit-test `bro…
MeAkib Oct 20, 2026
d97dc19
fixup! fix(@angular/build): name the provider packages in the unit-te…
MeAkib Oct 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/angular/build/src/builders/unit-test/runners/vitest/browser-provider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,8 @@ export async function setupBrowserConfiguration(
if (!providerName) {
errors ??= [];
errors.push(
'The "browsers" option requires either "playwright" or "webdriverio" to be installed within the project.' +
'The "browsers" option requires either "@vitest/browser-playwright", "@vitest/browser-webdriverio", ' +
'or "@vitest/browser-preview" to be installed within the project.' +
' Please install one of these packages and rerun the test command.',
);
}
Expand Down
23 changes: 23 additions & 0 deletions packages/angular/build/src/builders/unit-test/tests/options/browsers_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,5 +44,28 @@ describeBuilder(execute, UNIT_TEST_BUILDER_INFO, (harness) => {
`The "browsers" option requires either "@vitest/browser-playwright", "@vitest/browser-webdriverio", or "@vitest/browser-preview" to be installed`,
);
});

it('should name the provider packages when a runner config skips the dependency check', async () => {

@alan-agius4 alan-agius4 Oct 20, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this a duplicate of the above test?

@MeAkib MeAkib Oct 20, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It exercises a different path. With runnerConfig set, the up-front package check in index.ts is skipped, and the error comes from browser-provider.ts, which had the stale "playwright"/"webdriverio" wording. The two messages differ ("to be installed." versus "to be installed within the project."), but my assertion matched only the common prefix, so they looked the same. I've tightened the assertion to the text unique to the second path. I can also drop the test if you'd rather not cover it.

await harness.writeFile(
'vitest-base.config.mts',
`
import { defineConfig } from 'vitest/config';
export default defineConfig({});
`,
);

harness.useTarget('test', {
...BASE_OPTIONS,
runnerConfig: 'vitest-base.config.mts',
browsers: ['chrome'],
});

const { result, logs } = await harness.executeOnce();
expect(result?.success).toBeFalse();
expectLog(
logs,
`The "browsers" option requires either "@vitest/browser-playwright", "@vitest/browser-webdriverio", or "@vitest/browser-preview" to be installed within the project`,
);
});
});
});
Loading