Repository navigation
build: update dependency chokidar to v6 - #34466
Conversation
See associated pull request for more information. Closes angular#34464 as a pr takeover
There was a problem hiding this comment.
Code Review
This pull request upgrades the chokidar dependency from version 5.0.0 to 6.0.0. To accommodate Chokidar 6's behavior of keeping ancestor directories of explicitly watched package files un-ignored, the file watcher utility in packages/angular/build/src/utils/watcher.ts has been updated. Specifically, a new helper isNodeModulesSegment was introduced, isPathWatched was optimized to stop traversing when reaching a node_modules segment, and the ignore logic in createChokidarIgnored was adjusted to correctly prune unwatched descendants inside node_modules. There are no review comments to address, and I have no additional feedback to provide.
|
This PR was merged into the repository. The changes were merged into the following branches:
|
1 similar comment
|
This PR was merged into the repository. The changes were merged into the following branches:
|
Closes #34464 as a pr takeover