Repository navigation
[Backport 21.2.X] fix(@angular/build): escape prerender redirect URLs - #34508
Merged
alan-agius4 merged 2 commits intoOct 26, 2026
Merged
alan-agius4 merged 2 commits into
alan-agius4 merged 2 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces HTML escaping for URLs interpolated into static redirect pages to prevent potential injection vulnerabilities. It adds an escapeHtml utility and updates generateRedirectStaticPage to escape characters like ampersands, angle brackets, and quotes. Unit and end-to-end tests are also added to verify the escaping behavior. Feedback suggests adding a nullish coalescing fallback in escapeHtml to prevent returning undefined if the regex is modified in the future without updating the character map.
alan-agius4
approved these changes
Oct 26, 2026
Escape redirect targets before embedding them in the meta refresh tag and the fallback link of generated static redirect pages.
alan-agius4
force-pushed
the
fix/escape-prerender-redirect-urls-21.2.x
branch
from
October 26, 2026 10:29
448de28 to
647a33a
Compare
Collaborator
|
This PR was merged into the repository. The changes were merged into the following branches:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #33248