Repository navigation
docs: convert component sidenav to signals - #33910
Merged
Merged
Conversation
Member
|
There was a merge conflict that I tried resolving through Github, but I ended up breaking it 😓 Can you force push again and resolve the conflict? It's also fine to open another PR if that's easier. |
Replaces the `async` pipe usages in `ComponentSidenav` and `ComponentNav` with signals. The breakpoints are converted using `toSignal`, which also allows the templates to be simplified. `ComponentNav` was injecting `ActivatedRoute` to read the `section` param, because it isn't a routed component. Now `ComponentSidenav` receives the `section` param as an input through the router's component input binding and passes it down to `ComponentNav`, which loads the section's items through a `resource`. Adds a test that navigates through the routes and checks that the navigation lists the items of the section. Also fixes the sidenav closing logic which was checking the `isScreenSmall` observable instead of its value.
MeAkib
force-pushed
the
docs/component-sidenav-signals
branch
from
October 21, 2026 11:39
ba0e28c to
54c853a
Compare
Contributor
Author
Done |
crisbeto
approved these changes
Oct 21, 2026
Member
crisbeto
pushed a commit
that referenced
this pull request
Oct 21, 2026
Replaces the `async` pipe usages in `ComponentSidenav` and `ComponentNav` with signals. The breakpoints are converted using `toSignal`, which also allows the templates to be simplified. `ComponentNav` was injecting `ActivatedRoute` to read the `section` param, because it isn't a routed component. Now `ComponentSidenav` receives the `section` param as an input through the router's component input binding and passes it down to `ComponentNav`, which loads the section's items through a `resource`. Adds a test that navigates through the routes and checks that the navigation lists the items of the section. Also fixes the sidenav closing logic which was checking the `isScreenSmall` observable instead of its value. (cherry picked from commit 0b5260d)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the
asyncpipe usages inComponentSidenavandComponentNavwith signals. The breakpoints are converted usingtoSignal, which also allows the templates to be simplified.ComponentNavwas injectingActivatedRouteto read thesectionparam, because it isn't a routed component. NowComponentSidenavreceives thesectionparam as an input through the router's component input binding and passes it down toComponentNav, which loads the section's items through aresource. Adds a test that navigates through the routes and checks that the navigation lists the items of the section.Also fixes the sidenav closing logic which was checking the
isScreenSmallobservable instead of its value.