Repository navigation
Conversation
The combobox relayed keys to the popup through a single signal that an effect read later. When several keys arrived before the effect ran, only the last one reached the popup. Queue the events and relay all of them, in order, when the effect runs. Fixes angular#33973
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #33973.
ComboboxPatternrelays keys to the popup through a signal that holds only the latest event, and an effect re-dispatches it later. When two keys arrived before the effect ran, the first was overwritten and never reached the popup, so quick Down, Down, Down moved once and fast typeahead lost characters.The key handlers now queue each event, and the effect dispatches every queued event to the popup in order. I added a spec that sends keys back to back and checks that each one is handled; it fails without the change.