Repository navigation
fix(ui): full-bleed image preview with quiet zoom controls - #57318
Draft
kitlangton wants to merge 1 commit into
Draft
kitlangton wants to merge 1 commit into
kitlangton wants to merge 1 commit into
Conversation
kitlangton
force-pushed
the
image-preview-tasteful
branch
from
October 20, 2026 07:28
ba20e01 to
cfcb189
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Kit, comparing our image preview with Claude's:
− 74% + ×floating over the top-right of the image: "Can't we make this more tasteful? Should this be floating over it, or not show up until … above it, or in another control strip?"The preview put the image in a 1200 px panel with its own background, padding and shadow, and laid the controls in a header strip inside that panel.
What Changes
− 74% + │ ×sit in a small pill docked at the bottom centre, in the margin under the image, where Claude puts its pager. They never cover the image, and they use the menu surface and floating elevation tokens so they read in light and dark. Focus still starts on Close, and Tab,⌘ =,⌘ −,⌘ 0and Esc work as before.Placements considered (stills: https://problems.kitlangton.com/media/h_fW9tcxKQb7ihmW-p_Pig.png):
Scope
packages/uiimage preview only:image-preview.tsx,image-preview.cssand the story's docs. No change toimage-flight.ts, zoom math, springs or the open/close timing.Verification
bun run test:components component-tests/image-preview.spec.ts(4 passed).packages/ui:bun test src/components/image-flight.test.ts src/components/image-zoom.test.ts src/motion-tuning.test.tsbun typecheckin ui, app and session-ui;bun run lint:changed origin/betais clean.