Repository navigation
Conversation
Co-authored-by: MrMushrooooom <19261047+MrMushrooooom@users.noreply.github.com> (cherry picked from commit 580fcab)
There was a problem hiding this comment.
The merge looks sound. Its first parent is the dev merge-base and its second is production's tip, so production will become an ancestor of dev as intended. The diff against dev is exactly #56427 and #56430. The cherry-picked docs commit adds nothing because dev already has it, and the merge still applies cleanly to the current dev tip.
In packages/console/app, inferenceIp.test.ts passes (7/7) and typecheck passes. The worker and infra behaviour (the LegacyIngress binding and the Cloudflare provider pin) can't be run outside Cloudflare, so I haven't verified it at runtime.
Public API impact: none. This only touches the console worker and deployment infra.
No concerns. As you noted, this needs a merge commit, not a squash.
Issue for this PR
Closes #
Type of change
What does this PR do?
Merges
productionintodevsoproductionbecomes an ancestor ofdevand can be fast-forwarded (needed to ship #57328 / #56939 as incident containment). Brings over the two production-only fixes:The merge had no conflicts. Merge with a merge commit, not a squash. A squash would break the ancestry.
How did you verify your code works?
packages/console/apptypecheck passes, andtest/inferenceIp.test.tspasses.Checklist