Repository navigation
Conversation
ump45nose
requested review from
jbonofre,
kou,
laurentgo,
lidavidm and
wgtmac
as code owners
October 22, 2026 07:05
|
Thank you for opening a pull request! Please label the PR with one or more of:
Also, add the 'breaking-change' label if appropriate. See CONTRIBUTING.md for details. |
Author
|
The "Ensure PR format" check is only waiting for a label. Could a maintainer add |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed
The
apache-releaseprofile buildsarrow-java-root-<version>-source-release.zipwith the Apache parent'ssource-releaseassembly descriptor, which packs the whole working directory. In the release CI (ci/scripts/jni_full_build.sh . jni binaries) the pre-built JNI libraries are unpacked intojni/in the source tree before Maven runs, so they end up in that zip (~870 MB uncompressed for 18.3.0; the 19.0.0 zip is still ~455 MB).This adds
dev/release/source-release.xml, a copy of thesource-releasedescriptor fromapache-source-release-assembly-descriptor1.8 (the version used by the Apache parent POM) with one extra exclude for the top-leveljni/directory, and points the root POM'ssource-release-assemblyexecution at it. Nothing else about the zip changes;jni/directories undersrc/(Java packages) are not affected. I lefttesting/in, since it is needed to run the tests from the source release.Testing: I created a fake
jni/arrow_dataset_jni/x86_64/libarrow_dataset_jni.so(5 MB) in the checkout and ranmvn -pl .,bom -Papache-release package -Dgpg.skip=true -DskipTests ...:main: the zip is 8.5 MB, 2077 entries, and containsjni/arrow_dataset_jni/x86_64/libarrow_dataset_jni.sojni/entriesmvn -pl .,bom -Pspotless spotless:checkpasses.AI assistance disclosure: this change and description were prepared with the help of an AI coding assistant; the checks above were run locally.
Closes #743.