Skip to content

test: fix smoke test failures on xen/vmware - #13628

Merged
weizhouapache merged 9 commits into
apache:mainfrom
weizhouapache:4.23-fix-smoke-test-failures
Oct 23, 2026
Merged

weizhouapache merged 9 commits into
apache:mainfrom
weizhouapache:4.23-fix-smoke-test-failures

Conversation

@weizhouapache

Copy link
Copy Markdown
Member

Description

This PR fixes some smoke test failures on vmware or xenserver/xcpng

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Copilot AI lite review requested due to automatic review settings July 16, 2026 11:34
@boring-cyborg boring-cyborg Bot added component:integration-test Python Warning... Python code Ahead! labels Jul 16, 2026
@weizhouapache weizhouapache added this to the 4.23.0 milestone Jul 16, 2026
@weizhouapache

Copy link
Copy Markdown
Member Author

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

@weizhouapache weizhouapache added this to the 4.23.0 milestone Jul 16, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR targets integration smoke test stability across hypervisors (notably XenServer/XCP-ng and VMware) by skipping KVM-specific checks/tests when not running on KVM, and by adjusting a few timing/host prerequisite assumptions that can cause intermittent failures.

Changes:

  • Skip KVM-only paths in smoke tests when the detected hypervisor is not KVM.
  • Add additional host-tool prerequisite checks for a VPC source NAT IP update test.
  • Add delays around affinity-group migration steps and make the events-resource test more tolerant around volume attach/detach operations.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
test/integration/smoke/test_nonstrict_affinity_group.py Adds waits before migration steps in non-strict affinity group tests.
test/integration/smoke/test_network_extension_namespace.py Skips KVM prerequisite checks on non-KVM hypervisors; expands required host tools for one test.
test/integration/smoke/test_kms_lifecycle.py Skips a VM root-disk encryption test on non-KVM hypervisors.
test/integration/smoke/test_events_resource.py Wraps volume attach/detach operations to avoid hard failures in some environments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread test/integration/smoke/test_nonstrict_affinity_group.py
Comment thread test/integration/smoke/test_nonstrict_affinity_group.py
Comment thread test/integration/smoke/test_events_resource.py Outdated
@codecov

codecov Bot commented Jul 16, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 19.90%. Comparing base (5812290) to head (f947c85).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main   #13628   +/-   ##
=========================================
  Coverage     19.90%   19.90%           
- Complexity    20171    20177    +6     
=========================================
  Files          6372     6372           
  Lines        577180   577180           
  Branches      70693    70693           
=========================================
+ Hits         114869   114910   +41     
+ Misses       449755   449702   -53     
- Partials      12556    12568   +12     
Flag Coverage Δ
uitests 3.71% <ø> (ø)
unittests 21.17% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blueorangutan

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18593

@weizhouapache

Copy link
Copy Markdown
Member Author

@blueorangutan test ubuntu26 xcpng82 keepEnv

@blueorangutan

Copy link
Copy Markdown

@weizhouapache a [SL] Trillian-Jenkins test job (ubuntu26 mgmt + xcpng82) has been kicked to run smoke tests

@weizhouapache

weizhouapache commented Jul 16, 2026 •

Copy link
Copy Markdown
Member Author

@blueorangutan test ubuntu26 vmware-80u3e keepEnv

@blueorangutan

Copy link
Copy Markdown

@weizhouapache a [SL] Trillian-Jenkins test job (ubuntu26 mgmt + vmware-80u3e) has been kicked to run smoke tests

Copilot AI review requested due to automatic review settings July 17, 2026 09:41

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

Comment thread test/integration/smoke/test_network_extension_namespace.py
Comment thread test/integration/smoke/test_kms_lifecycle.py
Comment thread test/integration/smoke/test_events_resource.py
@weizhouapache

Copy link
Copy Markdown
Member Author

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18602

@weizhouapache

Copy link
Copy Markdown
Member Author

@blueorangutan test ubuntu26 xcpng82

@blueorangutan

Copy link
Copy Markdown

@weizhouapache a [SL] Trillian-Jenkins test job (ubuntu26 mgmt + xcpng82) has been kicked to run smoke tests

@weizhouapache

Copy link
Copy Markdown
Member Author

@blueorangutan test ubuntu26 vmware-80u3e

@blueorangutan

Copy link
Copy Markdown

@weizhouapache a [SL] Trillian-Jenkins test job (ubuntu26 mgmt + vmware-80u3e) has been kicked to run smoke tests

@blueorangutan

Copy link
Copy Markdown

[SF] Trillian Build Failed (tid-7)

@weizhouapache

Copy link
Copy Markdown
Member Author

@blueorangutan test ubuntu26 vmware-80u3

@blueorangutan

Copy link
Copy Markdown

@weizhouapache a [SL] Trillian-Jenkins test job (ubuntu26 mgmt + vmware-80u3) has been kicked to run smoke tests

@blueorangutan

Copy link
Copy Markdown

[SF] Trillian Build Failed (tid-9)

@blueorangutan

Copy link
Copy Markdown

[SF] Trillian Build Failed (tid-48)

@blueorangutan

Copy link
Copy Markdown

[SF] Trillian Build Failed (tid-50)

@blueorangutan

blueorangutan commented Sep 25, 2026 •

Copy link
Copy Markdown

[SF] Trillian test result (tid-46)
Environment: xcpng83 (x2), zone: Advanced Networking with Mgmt server u26
Total time taken: 76081 seconds
Marvin logs: [archive removed]
Smoke tests completed. 155 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_1_userdata_on_ssvm Error 8.62 test_systemvm_userdata.py

@blueorangutan

blueorangutan commented Sep 25, 2026 •

Copy link
Copy Markdown

[SF] Trillian test result (tid-49)
Environment: vmware-80u3 (x2), zone: Advanced Networking with Mgmt server u26
Total time taken: 91199 seconds
Marvin logs: [archive removed]
Smoke tests completed. 153 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_08_upgrade_kubernetes_ha_cluster Failure 3698.26 test_kubernetes_clusters.py
test_13_test_add_external_nodes_to_cluster Failure 1009.38 test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown Error 1097.86 test_kubernetes_clusters.py
test_05_list_volumes_isrecursive Failure 0.06 test_list_volumes.py
test_07_list_volumes_listall Failure 0.05 test_list_volumes.py
test_list_vms_metrics_admin Error 3627.05 test_metrics_api.py
test_list_vms_metrics_history Error 8.74 test_metrics_api.py
test_list_volumes_metrics_history Error 3625.81 test_metrics_api.py

@weizhouapache

Copy link
Copy Markdown
Member Author

@blueorangutan test ubuntu26 vmware-70u3

@blueorangutan

Copy link
Copy Markdown

@weizhouapache a [SL] Trillian-Jenkins test job (ubuntu26 mgmt + vmware-70u3) has been kicked to run smoke tests

@blueorangutan

Copy link
Copy Markdown

[SF] Trillian Build Failed (tid-55)

@weizhouapache

Copy link
Copy Markdown
Member Author

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 19357

@weizhouapache

Copy link
Copy Markdown
Member Author

@blueorangutan test ubuntu26 vmware-70u3

@blueorangutan

Copy link
Copy Markdown

@weizhouapache a [SL] Trillian-Jenkins test job (ubuntu26 mgmt + vmware-70u3) has been kicked to run smoke tests

@blueorangutan

blueorangutan commented Oct 1, 2026 •

Copy link
Copy Markdown

[SF] Trillian test result (tid-56)
Environment: vmware-70u3 (x2), zone: Advanced Networking with Mgmt server u26
Total time taken: 69822 seconds
Marvin logs: [archive removed]
Smoke tests completed. 153 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_13_test_add_external_nodes_to_cluster Error 831.30 test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown Error 920.38 test_kubernetes_clusters.py
test_05_list_volumes_isrecursive Failure 0.06 test_list_volumes.py
test_07_list_volumes_listall Failure 0.06 test_list_volumes.py
test_08_migrate_vm Error 29.32 test_vm_life_cycle.py

@blueorangutan

blueorangutan commented Oct 3, 2026 •

Copy link
Copy Markdown

[SF] Trillian test result (tid-57)
Environment: vmware-70u3 (x2), zone: Advanced Networking with Mgmt server u26
Total time taken: 101910 seconds
Marvin logs: [archive removed]
Smoke tests completed. 152 look OK, 3 have errors, 1 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_08_upgrade_kubernetes_ha_cluster Failure 3689.65 test_kubernetes_clusters.py
test_13_test_add_external_nodes_to_cluster Error 834.28 test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown Error 910.87 test_kubernetes_clusters.py
test_01_deploy_vm_on_specific_host Error 3603.93 test_vm_deployment_planner.py
test_02_deploy_vm_on_specific_cluster Error 2.48 test_vm_deployment_planner.py
test_03_deploy_vm_on_specific_pod Error 2.56 test_vm_deployment_planner.py
test_04_deploy_vm_on_host_override_pod_and_cluster Error 1.43 test_vm_deployment_planner.py
test_05_deploy_vm_on_cluster_override_pod Error 2.49 test_vm_deployment_planner.py
test_09_expunge_vm Failure 423.76 test_vm_life_cycle.py
all_test_vm_strict_host_tags Skipped --- test_vm_strict_host_tags.py

@weizhouapache

Copy link
Copy Markdown
Member Author

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 19673

@weizhouapache

Copy link
Copy Markdown
Member Author

@blueorangutan test ol8 vmware-70u3

@blueorangutan

Copy link
Copy Markdown

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + vmware-70u3) has been kicked to run smoke tests

@weizhouapache

Copy link
Copy Markdown
Member Author

@blueorangutan test ol8 xcpng82

@blueorangutan

Copy link
Copy Markdown

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + xcpng82) has been kicked to run smoke tests

@blueorangutan

blueorangutan commented Oct 23, 2026 •

Copy link
Copy Markdown

[SF] Trillian test result (tid-17210)
Environment: vmware-70u3 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 85281 seconds
Marvin logs: [archive removed]
Smoke tests completed. 155 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_08_upgrade_kubernetes_ha_cluster Failure 3706.60 test_kubernetes_clusters.py
test_05_list_volumes_isrecursive Failure 0.06 test_list_volumes.py
test_07_list_volumes_listall Failure 0.05 test_list_volumes.py

@weizhouapache

Copy link
Copy Markdown
Member Author

@nvazquez @RosiKyu
there are some intermittent failures on vmware and xcpng. most of the test failures are gone.
do you think we can merge this PR to 24.0 ?

@nvazquez

Copy link
Copy Markdown
Contributor

Thanks @weizhouapache, looks good to me

@weizhouapache

Copy link
Copy Markdown
Member Author

thanks @nvazquez @DaanHoogland
I am merging . If there are new failures, we could address in another PR

@weizhouapache
weizhouapache merged commit 1b4f19e into apache:main Oct 23, 2026
26 of 28 checks passed
@github-project-automation github-project-automation Bot moved this from In review to Done in CloudStack Testing Oct 23, 2026
@weizhouapache
weizhouapache deleted the 4.23-fix-smoke-test-failures branch October 23, 2026 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

7 participants