[bhouse-nexthop]

Description

IPv6 network ACL rules given by protocol number are now matched with meta l4proto, the expression nft itself uses for tcp, udp and icmpv6 rules. Every IPv6 ACL rule then identifies the protocol the same way. A rule given by the number of an IPv6 extension header (0, 43, 44, 60, 135) is matched as that extension header (exthdr <name> exists).

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

How Has This Been Tested?

• New systemvm/test/TestCsAclIpv6.py checks the rendered ingress and egress rules, including extension header numbers.
• The generated rules were loaded into nft through CsNetfilters.apply_ip6_rules() and checked against traffic.
• meta l4proto and exthdr ... exists were checked to load on nft 1.0.6, the version in the Debian 12 systemvm template.
• pycodestyle and pylint (as in systemvm/test/runtests.sh) report nothing new.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 18.12%. Comparing base (8074c3e) to head (91794f9).

Additional details and impacted files

@@             Coverage Diff              @@
##               4.22   #14360      +/-   ##
============================================
- Coverage     18.13%   18.12%   -0.01%     
+ Complexity    16445    16443       -2     
============================================
  Files          5939     5939              
  Lines        537306   537306              
  Branches      65867    65867              
============================================
- Hits          97439    97402      -37     
- Misses       428749   428796      +47     
+ Partials      11118    11108      -10     

Flag	Coverage Δ
uitests	4.04% <ø> (ø)
unittests	19.20% <ø> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[bhouse-nexthop]

@vladimirpetrov @sureshanaparti could you take a look at this one? We'd like this fix to make it into the upcoming 4.22.2 release.

[Damans227]

thanks @bhouse-nexthop, fix looks right. good to go from my side

[weizhouapache]

@blueorangutan package

[blueorangutan]

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[bhouse-nexthop]

@weizhouapache thanks for kicking the packaging. Could you also run the tests and add it to the 4.22.2 milestone? @Damans227 reviewed it on 10-08; it still needs a committer review. I understand 4.22.2 is due out late this week or early next.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 19681

[weizhouapache]

@blueorangutan test

[blueorangutan]

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests