Repository navigation
ldap: use ldaps:// scheme when adding LDAP config if SSL is enabled - #14452
Open
weizhouapache wants to merge 1 commit into
Open
weizhouapache wants to merge 1 commit into
weizhouapache wants to merge 1 commit into
Conversation
addConfigurationInternal always built the connectivity-test provider URL with the plain ldap:// scheme, even when domain/global SSL (truststore) settings are configured, unlike LdapConfiguration.getProviderUrl() used elsewhere which already selects ldaps:// based on SSL status.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #14452 +/- ##
============================================
+ Coverage 18.05% 20.34% +2.28%
- Complexity 16320 21412 +5092
============================================
Files 5937 6493 +556
Lines 536919 597289 +60370
Branches 65810 74776 +8966
============================================
+ Hits 96932 121492 +24560
- Misses 428915 462595 +33680
- Partials 11072 13202 +2130
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the issue below:
addConfigurationInternal always built the connectivity-test provider URL with the plain ldap:// scheme, even when domain/global SSL (truststore) settings are configured, unlike LdapConfiguration.getProviderUrl() used elsewhere which already selects ldaps:// based on SSL status.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?