Repository navigation
Core: fix field access display for digit-prefixed identifiers - #2707
Open
princejain756 wants to merge 1 commit into
Open
princejain756 wants to merge 1 commit into
princejain756 wants to merge 1 commit into
Conversation
A field access whose target identifier starts with a digit, as in SELECT [dbo]. 1te_sk in Hive, displayed without the space as [dbo].1te_sk. On re-lexing, .1 is read as a number, so the output parsed as a different statement or failed to parse. AccessExpr::Dot now writes ' . ' before an unquoted identifier starting with a digit, extending the existing handling for numeric literals from apache#2463. Fixes apache#2589
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Hive,
SELECT [dbo]. 1te_sk = 1parses to a field access on1te_sk, but displayed asSELECT [dbo].1te_sk = 1, which fails to reparse:.1is lexed as a number, so[dbo].1te_skreads as an array expression with alias.1te_sk.AccessExpr::Dotnow writes.before an unquoted identifier starting with a digit, extending the spacing already used for numeric literal access targets (#2463). Quoted identifiers are unchanged since"1x"cannot merge with the dot.Fixes #2589
AI assistance: this change was implemented with help from an AI coding agent; the behavior and tests were verified manually.