Repository navigation
Generic, SQLite: parse WITH ... AS [NOT] MATERIALIZED - #2708
Open
princejain756 wants to merge 1 commit into
Open
princejain756 wants to merge 1 commit into
princejain756 wants to merge 1 commit into
Conversation
supports_cte_materialization() covered PostgreSQL and DuckDB only, so the generic dialect (the DataFusion default) and SQLite rejected the directive even though SQLite accepts it and DataFusion supports it through the generic dialect. Refs apache#2622
princejain756
force-pushed
the
generic-sqlite-cte-materialized
branch
from
October 21, 2026 14:18
de28b20 to
d65c76d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WITH c AS MATERIALIZED (SELECT 1)was rejected byGenericDialect(the DataFusion default) andSQLiteDialect; only PostgreSQL and DuckDB enabledsupports_cte_materialization().Both engines support the directive: SQLite since 3.35 (docs, verified against
sqlite3), and Generic covers the DataFusion use case described in the issue.MATERIALIZEDdirectly afterASis not ambiguous with other syntax.Refs #2622
AI assistance: this change was implemented with help from an AI coding agent; the behavior and tests were verified manually.