Repository navigation
Conversation
getIterators checked retryCount only for HashJoinCacheNotFoundException, so a persistent StaleRegionBoundaryCacheException recursed through recreateIterators until StackOverflowError. Check the retry budget for every recoverable exception, including the local index build ColumnFamilyNotFoundException path, and rethrow once it is exhausted. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
🟢 Approval recommended
The retry accounting is correct and covered by focused regression tests.
0 open findings
What changed in this PR
Bounds recoverable scan retries to prevent recursive stack overflow.
Changes:
- Applies retry limits to stale-region and local-index failures.
- Decrements retry counts consistently.
- Adds regression tests for both paths.
| File | Description |
|---|---|
BaseResultIterators.java |
Enforces retry exhaustion. |
BaseResultIteratorsRetryTest.java |
Verifies bounded retries. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getIterators checked retryCount only for HashJoinCacheNotFoundException, so a persistent StaleRegionBoundaryCacheException recursed through recreateIterators until StackOverflowError. Check the retry budget for every recoverable exception, including the local index build ColumnFamilyNotFoundException path, and rethrow once it is exhausted.
Co-Authored-By: Claude Opus 5.5 noreply@anthropic.com