Repository navigation
chore: raise dependency cooldown to 7 days - #1202
Open
filakovsky wants to merge 1 commit into
Open
filakovsky wants to merge 1 commit into
filakovsky wants to merge 1 commit into
Conversation
Raise the minimum release age to at least 7 days (pnpm, uv, Renovate) so newly published versions aren't installed until they've been public for a week. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1202 +/- ##
==========================================
+ Coverage 89.89% 93.14% +3.25%
==========================================
Files 54 54
Lines 3691 3691
==========================================
+ Hits 3318 3438 +120
+ Misses 373 253 -120
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
apify-factory
left a comment
Contributor
There was a problem hiding this comment.
Looks good, nothing blocking.
🏭 Factory review — ℹ️ not auto-approved
This change was reviewed but cannot be auto-approved: a gate failed, so the review cannot end in an approval.
| check | result |
|---|---|
| Static gates | ❌ 12/16 — max-lines, file-extensions, deny-globs, patch-present |
| Review findings | ✅ none |
| Reviewer escalation | ❌ Supply-chain policy change that rewrites both lockfiles (including a new transitive dependency, pastel), and the omitted lockfile contents can only be judged from the diff. |
Juror 1 — claude-sonnet-5-5, adversarial |
⏭️ skipped — a gate failed |
Why it was not auto-approved
Failed gates:
max-lines: 1948 changed lines (+973/-975), limit 200file-extensions: disallowed extension: pyproject.toml, renovate.json, uv.lock, website/pnpm-lock.yaml, website/pnpm-workspace.yamldeny-globs: website/pnpm-lock.yaml matches **/pnpm-lock.yamlpatch-present: no text diff for uv.lock, website/pnpm-lock.yaml
The comments above are the review itself; this section only explains the approval decision. Push a change and request @apify-factory again to re-run it, or ask a human to review.
Reviewed 92d41e758 · workflow run
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raises the dependency cooldown to at least 7 days for every package manager in this repo, so a newly published (and possibly compromised) version isn't installed until it has been public for a week.
Changes
website/pnpm-workspace.yaml:minimumReleaseAge1440 → 10080 (24 hours → 7 days)pyproject.toml:exclude-newer"24 hours" → "7 days"renovate.json:minimumReleaseAge1 day → 7 daysLockfiles
website/pnpm-lock.yaml: pnpm 12 checks the lockfile againstminimumReleaseAgeon frozen installs, so these entries published less than 7 days ago were moved back to the newest older release:asn1js@3.1.0,baseline-browser-mapping@2.11.29,electron-to-chromium@1.5.459,lilconfig@3.1.4,markdown-it@14.3.3,node-releases@2.0.59,qs@6.16.1,react@19.3.1,react-dom@19.3.1,schema-utils@4.6.0,undici@7.30.1,watchpack@2.6.2,webpack@5.112.0uv.lock: re-locked, because uv records the cooldown in the lockfile. These packages moved back to releases that are at least 7 days old:Notes
🤖 Generated with Claude Code