Repository navigation
Conversation
get_secrets_by_name and SecretsProvider.get_multiple document that they raise GetParameterError, but GetSecretError subclassed Exception, so `except GetParameterError` missed it. Also export GetSecretError from aws_lambda_powertools.utilities.parameters. Closes aws-powertools#8595 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
|
Contributor
|
Duplicated #8611 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: closes #8595
Summary
Changes
GetSecretErrornow subclassesGetParameterError, matching the docstrings ofget_secrets_by_nameandSecretsProvider.get_multiple("Raises GetParameterError").GetSecretErroris exported fromaws_lambda_powertools.utilities.parameters.SecretsProvider.get_multiplefailure is caught bypytest.raises(GetParameterError).Existing code that catches
GetSecretErrorkeeps working; this only widens whatexcept GetParameterErrorcatches.User experience
Before:
After: the
except GetParameterErrorblock catches it, andparameters.GetSecretErroris importable from the package.Tests:
pytest tests/functional/parameters→ 139 passed.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.
🤖 Generated with Claude Code