Repository navigation
fix(event_handler): make HttpResolverLocal usable as a Lambda handler - #8634
Open
jasperdingg wants to merge 1 commit into
Open
jasperdingg wants to merge 1 commit into
jasperdingg wants to merge 1 commit into
Conversation
- __call__ dispatches (event, context) to resolve() and (scope, receive, send) to the ASGI handler. The async handler is also exposed as the instance's __call__ attribute so uvicorn and hypercorn still detect an ASGI3 application. - Map v2 payload events (HTTP API, Function URL) to APIGatewayProxyEventV2. - Base64-encode request bodies that are not valid UTF-8. Refs aws-powertools#8582 (item 3)
|
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: closes #8582 (item 3; items 1 and 2 are in #8633)
Summary
Changes
HttpResolverLocal.__call__now works as both a Lambda handler(event, context)and an ASGI app(scope, receive, send). The async ASGI handler is also set as the instance's__call__attribute, so uvicorn and hypercorn still detect it as an ASGI3 app.APIGatewayProxyEventV2instead of failing withKeyError: 'httpMethod'.UnicodeDecodeError.User experience
Before:
handler = appraisedTypeError: missing 'send', v2 events raisedKeyError, and binary bodies through ASGI raisedUnicodeDecodeError.After:
handler = appworks in Lambda for REST, HTTP API and Function URL events, the same app still runs under uvicorn and hypercorn, and binary bodies arrive base64-encoded.Tested w/ new tests in
test_http_resolver.py, plus a manual run under uvicorn on Python 3.11 and 3.14.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.