Repository navigation
fix: avoid whitespace-only CIMD collision lines - #178
Merged
schultzp2020 merged 2 commits intoOct 13, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Patch published
@backstage/rename-experimental-cimd-config@0.2.0(issue #142) collision formatting without changing the recipe in draft #159. ASTrange().start.indexcounts UTF-8 bytes, butroot.source()slices count JavaScript characters; a✨earlier in Backstageapp-config.yamlshifted the insertion past the key's two-space indent, yielding a whitespace-only line. Derive line text from AST line/column, insert the block TODO at the AST key byte offset, and retain flow-pair spacing. Add a patch changeset; do not edit package/manifest versions.Evidence
utf8-prefix-collisionfixture (CRLF, preceding✨, indented block collision) failed before fix with extra+;utf8-flow-collisioncovers Unicode before a same-line flow pair. Green: package 15/15 fixtures plus workflow validation pass; existing comment, collision-idempotence, flow/block, and CRLF fixtures remain green.app-config.yamlpreimage at0863f034:git diff --check→app-config.yaml:438: trailing whitespace.Local patched shipped workflow applied to a fresh tracked disposable target: one TODO line, no whitespace-only insertion,git diff --checkclean; second apply (--allow-dirty --no-interactive) byte-identical (SHA-25631b83adc0958e7d2a15d226e251bfc5124e837b6dcf2421a2e8d3105de272cf7). No recipe override/postprocessor.yarn format,yarn lint,yarn test,yarn check:changedpassed. Husky pre-commit ran lint-staged format/lint/package tests; normal push ran pre-push changed-file gates.git diff --checkclean.Merge Danger
Door: two-way. Independent review required before merge. Blast radius: collision-comment insertion in this one YAML codemod; key rename, non-collisions, comments, flow/block YAML, and repeat idempotence remain fixture-covered. PR #159 stays draft until this patch merges, a new Version Packages PR is manually merged by the user, and patched registry package publishes; then rerun #159 QA against the new registry version. Do not merge #159, publish manually, or treat this source-only PR as a registry release.