Repository navigation
Conversation
was broken in previous refactor for UX styling
|
|
||
| const confidence = data.confidence > 0.6 ? 'high' : 'low'; | ||
| generateConfidence = (data) => { | ||
| return data.confidence > 0.6 ? 'high' : 'low'; |
There was a problem hiding this comment.
There's an edge case, when the confidence score it's not provided. we should think about how to handle that. coz with the current setup, everything is then mark as low confidence, which is not very helpful.
But yeah this could be a separate ticket.
|
I'd suggest possibly merging PR #54 (comment) into this branch, before merging to master, as it has a fix on the splitting paragraph issue. and fixing the merge conflict on that refactor shouldn't be too bad 🤞. |
A bit of cleanup with leftover functions still to do. Trying to sync state between the component and html player. isPauseWhileTypingOn wasn't being set, so moved that state to parent component and logic to the editor
|
|
|
The latest commit of moving the play/pause in the state before changing the video element, might be causing performance issues when using When you start typing you would get a significant delay, where you won't see the text being updated on screen. until you stop typing. this might be is a new bug(?). |
as it was not being used https://draftjs.org/docs/api-reference-key-binding-util#hascommandmodifier
there where two functions doing the same thing
if confidence scores not present then mark all as high -eg importing from autoEdit or other providers that don't have confidence scored
No description provided.