Repository navigation
Conversation
Size Report
Startup median (7 runs, lower is better):
|
|
This PR is ready at 34a33e8, and I found no problems in the gesture adapter changes. All 15 checks pass, and the local check:affected timeout in apple-platform-output-guard.test.ts does not overlap with this diff, which touches only client-gesture.ts types and the agent-device-client.ts gesture adapters; the PR body says it reproduces on the unchanged base. There are no conflicts, and nothing else must happen before merge. Not blocking: there is no SDK-level test that calls transformGesture and asserts its structured gesture input, unlike pan, drag, tap and rotate; a test beside the one for pan in src/tests/agent-device-client.test.ts, expecting kind transform, origin, delta, scale, degrees and durationMs, would catch a wrong kind or projection, and you can take or leave it. I read the payload types to check that they match, but I did not run tsc or the tests. I did not re-run the local failure, and I did not search external consumers of the exported DragOptions, TapGestureOptions and SwipeGestureOptions; their names and shapes look unchanged by inspection. |
Summary
Simplify gesture SDK adapters: derive drag, tap, and swipe-preset options from existing payload types, inline helpers that only add
kind, share pan/transform coordinate projection, and keep center validation beside its caller.Two files, 39 fewer production lines. Public signatures, wire payloads, field precedence, and errors are preserved. No new files or dependencies. SDK-only scope; native executors and daemon dispatch are unchanged. Follow-up to #3852; no linked issue.
Validation
34a33e84cc9901cfd9729c36c93af1c8fa8aca85. Independent review: no findings.pnpm check:affected --run --head 34a33e84cc9901cfd9729c36c93af1c8fa8aca85failed (run-vK9A6Z,exactCommit=true): 949 passed; fakerecordexceeded 20 seconds atapple-platform-output-guard.test.ts:384. Structural checks passed.f8c60ca188f62e110bdc1d3e6225b134960886c0—pnpm exec vitest related --run --passWithNoTests packages/contracts/src/client-gesture.ts src/agent-device-client.ts—reproduced the identical failure/counts. Isolated checkout removed.run-SRBMb9). CI success does not replace the failed local receipt. Draft retained pending resolution of that local blocker; no live-device verification claimed.