Repository navigation
refactor(android): centralize touch parsing and fill reporting - #3855
Conversation
Size Report
Startup median (7 runs, lower is better):
|
|
This PR is ready at 15f17c4. All 16 checks pass with none failing, and the touch-reply and shell-fill paths this diff changes are covered by the CI unit tests. I did not run tests locally. The Pixel 7 and native-field runs in the description are author-reported and I did not reproduce them. Since the diff is a behavior-preserving move, I think they are enough. There are no conflicts, and nothing else stands in the way of merging. Not blocking: the moved reply parser has three throw branches (wrong protocol, stale requestId, missing blank-line separator), and the protocol test in |
|
Thanks. I am leaving the optional test additions out under the user's explicit no-new-tests constraint. The earlier manual malformed-reply probes cover dispatch disclosure and retirement, but do not pin every parser precedence combination in the permanent suite. The shell loop keeps evidence construction before completion because it must inspect the unconfirmed result to decide whether its shell-specific retry is allowed. |
Summary
Follow up on the review of #3849, which has merged:
Two commits, five files: production +25/−20, existing test +3/−5. The existing parser test calls the renamed entrypoint; no new tests or cases were added.
Validation
Head
15f17c47ddf81e842c81e348a0b4f5549bd9a06e, basef8c60ca188f62e110bdc1d3e6225b134960886c0:pnpm check:affected --run --head 15f17c47dd: passed, 2,316 tests. Receipt.tmp/validation/run-2UkGNn/receipt.json:exactCommit=true,checkoutChanged=false. CLI/native helper builds passed. Claude review: no remaining findings.dispatched: unknown.adb-shell, correctunconfirmedevidence, exactly one warning.An earlier local run hit four provider timeouts. The unchanged base, those 14 focused tests, and the final full affected run subsequently passed; the initial cause remains unproven. CI coverage, integration, and native smoke checks remain pending.