Skip to content

Keep jakartaee-bom out of cloudevents-bom - #750

Closed
AdzerKI wants to merge 1 commit into
cloudevents:mainfrom
AdzerKI:bom-without-jakartaee
Closed

Keep jakartaee-bom out of cloudevents-bom#750
AdzerKI wants to merge 1 commit into
cloudevents:mainfrom
AdzerKI:bom-without-jakartaee

Conversation

@AdzerKI

@AdzerKI AdzerKI commented Oct 7, 2026

Copy link
Copy Markdown

Fixes #749.

The jakarta.jakartaee-bom import moves from cloudevents-parent to http/restful-ws-jakarta and http/restful-ws-jakarta-integration-tests, so cloudevents-bom no longer carries it to consumers. ./mvnw verify passes, and the effective POM of bom manages only CloudEvents modules.

@AdzerKI
Keep jakartaee-bom out of cloudevents-bom
bb7c756 
cloudevents-bom inherits the dependencyManagement of cloudevents-parent,
so importing it also imports jakarta.jakartaee-bom and pins Jakarta API
versions in consumer builds. Move the import to the restful-ws-jakarta
modules, the only ones that need it.

Signed-off-by: AdzerKI <silver_cat@list.ru>
@Cali0707

Cali0707 commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

Hey @jacekbilski mind taking a pass at reviewing this PR? Seems related to some of your recent work

@jacekbilski

jacekbilski commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

In #754 I propose to actually fix the BOM, so that it only contains cloudevents' modules and a few other things. Your proposed solution goes a bit against what I wanted, that is having a one central place for defining Jakarta EE dependencies. My solution leaves the build as-is, and controls far better what gets into BOM directly in BOM module.

@AdzerKI, I guess that should also solve your problem. Could you verify that?

@AdzerKI

AdzerKI commented Oct 21, 2026

Copy link
Copy Markdown
Author

Verified: with #754 the flattened bom/pom.xml has no parent and manages only the io.cloudevents modules, so importing cloudevents-bom no longer brings in jakarta.jakartaee-bom. That solves #749, and it keeps the Jakarta EE versions in one place as you want, so I'm closing this one in favour of #754.

@AdzerKI AdzerKI closed this Oct 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

cloudevents-bom pulls in jakarta.jakartaee-bom from the parent

3 participants

@AdzerKI @Cali0707 @jacekbilski