You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Stale Access application path-param tests expect valid account_id to raise #2747
Confirm this is a Python library issue and not an underlying Cloudflare API issue.
This is an issue with the Python library
Describe the bug
Some skipped path-param tests for zero_trust.access.applications appear to be stale after the account/zone path selection logic was fixed.
For example, these tests still expect ValueError("You must provide either account_id or zone_id") when account_id="account_id" is provided:
test_path_params_create_overload_1 in tests/api_resources/zero_trust/access/test_applications.py
test_path_params_list in both sync and async sections of the same file
That expectation now contradicts the current resource implementation, which correctly treats account_id as sufficient and builds an /accounts/{account_id}/... path. This looks related to the behavior discussed in #2705, where passing account_id should not require zone_id.
I noticed this while checking #2705. The runtime behavior on current main looks correct, but the skipped generated tests still encode the old/broken expectation.
To Reproduce
Inspect the current main version of tests/api_resources/zero_trust/access/test_applications.py.
Compare with the current implementation in src/cloudflare/resources/zero_trust/access/applications/applications.py, where account_id selects the accounts path and does not need zone_id.
A minimal local smoke check confirms the current behavior builds GET /accounts/acct_123/access/apps for client.zero_trust.access.applications.list(account_id="acct_123").
Expected: the path-param tests should only expect an error for empty/missing account and zone identifiers, not for a non-empty account_id.
Code snippets
client.zero_trust.access.applications.list(account_id="acct_123")
# current main builds: GET /accounts/acct_123/access/apps
Activity