Repository navigation
Updating version for pip for latest - #1246
Open
ari-wg-gitbot wants to merge 4 commits into
Open
ari-wg-gitbot wants to merge 4 commits into
ari-wg-gitbot wants to merge 4 commits into
Conversation
for stack(s) cflinuxfs4, cflinuxfs5
pip's pyproject.toml declares 'flit-core >=3.11,<4' as a build
dependency. When BP_PIP_VERSION=latest triggers InstallPip(), the
existing code runs 'pip install pip' with build isolation enabled,
which tries to satisfy the flit-core <4 constraint. Since the manifest
now carries flit-core 4.1.0, the constraint cannot be satisfied and
staging fails with:
ERROR: Could not find a version that satisfies the requirement
flit-core<4,>=3.11 (from versions: 4.1.0)
Add --no-build-isolation to skip build-dependency resolution, matching
the existing pattern used by InstallCommonBuildDependencies() for the
vendored sdist path. This is safe because pip's source tarball can be
built with flit-core 4.x — the <4 upper bound in pyproject.toml is a
conservative constraint, not a hard incompatibility.
The previous --no-build-isolation fix changed the failure from a version constraint error to ModuleNotFoundError: No module named 'flit_core'. With --no-build-isolation, pip skips the isolated build environment but still needs flit_core importable in the system Python to build pip from its source tarball. The flit-core wheel is bundled inside the pip dependency tarball (/tmp/pip) but was never installed into the Python environment. Fix by bootstrapping flit-core from the bundled wheel before installing pip. The sequence is now: 1. Extract pip dependency to /tmp/pip (contains pip sdist + flit-core wheel) 2. pip install flit-core --no-index --no-build-isolation --find-links=/tmp/pip 3. pip install pip --no-index --no-build-isolation --find-links=/tmp/pip This matches the existing pattern in InstallCommonBuildDependencies() which bootstraps flit-core before using it for the vendored sdist path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated update of pip dependency for version line latest.