Repository navigation
Add support for custom comparators and reporters - #48
Conversation
… comparators and reporters
… comparators and reporters
# Conflicts: # java-snapshot-testing-core/src/main/java/au/com/origin/snapshots/SnapshotConfig.java
- decoupled comparator and reporter - changed reporters helper method on Snapshot.java to accept a varargs reporters
|
@juja0 can you squash all 13 commits into a single one? |
| ### Example: JsonObjectComparator | ||
| The default comparator may be too strict for certain types of data. | ||
| For example, when comparing json objects, formatting of the json string or the order of fields | ||
| may not be of much importance during comparison. A custom serializer can help in such cases. |
There was a problem hiding this comment.
a custom serializer comparator
|
Did you end up trying |
|
Hey, yes I'll squash the commits. Isn't that something that shows up as an option during merge though ? I don't remember seeing an option while raising the PR. Shall I squash during merge or do you want me to do it right now ? I did try relocating. It didn't work. Quoting my comment from the previous MR just in case you missed it.
|
|
Ah yeah - didn't know Github supported automatic squash - that's nice. Thanks for your help with these features - they offer some good enhancements. |
No description provided.