Dev: DatabaseException might not be thrown even if query fails #6913

Activity

1. kenjis

   added

   dev

   databaseIssues or pull requests that affect the database layerIssues or pull requests that affect the database layer

   on Nov 27, 2022
2. kenjis

   changed the title [-]Dev: DatabaseException may not be thrown if query fails[/-] [+]Dev: DatabaseException may not be thrown even if query fails[/+] on Nov 27, 2022
3. kenjis

   changed the title [-]Dev: DatabaseException may not be thrown even if query fails[/-] [+]Dev: DatabaseException might not be thrown even if query fails[/+] on Jan 27, 2024
4. kenjis commented on Jan 27, 2024

   

   kenjis

   on Jan 27, 2024

   Last edited by kenjis

   MemberAuthor

   More actions

   SQLite3

   --- a/app/Config/Boot/testing.php
   +++ b/app/Config/Boot/testing.php
   @@ -14,7 +14,7 @@
     | make sure they don't make it to production. And save us hours of
     | painful debugging.
     */
   -error_reporting(E_ALL);
   +error_reporting(E_ALL & ~E_WARNING);
    ini_set('display_errors', '1');
    
    /*

   $ vendor/bin/phpunit tests/system/Database/Live/TransactionTest.php 
   PHPUnit 9.6.16 by Sebastian Bergmann and contributors.
   
   Runtime:       PHP 8.2.15
   Configuration: /Users/kenji/work/codeigniter/official/CodeIgniter4-4.5/phpunit.xml
   
   F...                                                                                                                         4 / 4 (100%)
   
   Time: 00:00.231, Memory: 18.00 MB
   
   There was 1 failure:
   
   1) CodeIgniter\Database\Live\TransactionTest::testTransStartDBDebugTrue
   Failed asserting that null is an instance of class "CodeIgniter\Database\Exceptions\DatabaseException".
   
   /Users/kenji/work/codeigniter/official/CodeIgniter4-4.5/tests/system/Database/Live/TransactionTest.php:106
   
   FAILURES!
   Tests: 4, Assertions: 14, Failures: 1.

   SQLSRV driver has different implementation. It throws Exception when the query return value is false.

   This is correct.
   SQLite3, Postgres and OCI8 drivers should throw Exception when the query return value is false.
5. wakqasahmed

   added 4 commits that reference this issue on Sep 19, 2026

   style: satisfy Rector for Postgre errors (codeigniter4#6913)

   6d7297a

   fix: throw Postgre query errors with warnings disabled (codeigniter4#…

   ...

   255f703

   style: satisfy Rector for Postgre errors (codeigniter4#6913)

   2825ce0

   docs: add changelog entry for Postgre query errors (codeigniter4#6913)

   2382e28
6. paulbalandan

   added a commit that references this issue on Sep 27, 2026

   fix: throw Postgre query errors with warnings disabled (#10573)

   ...

   fba4362