Repository navigation
[Model] Upsert problem with data validation, allowed fields, dates defined #7286
Description
PHP Version
7.4
CodeIgniter4 Version
4.3.2
CodeIgniter4 Installation Method
Composer (as dependency to an existing project)
Which operating systems have you tested for this bug?
Windows, Linux
Which server did you use?
apache
Database
MySQL (ver. 8.0.28)
What happened?
Upsert does not work correctly with the model.
Allowed fields, validation rules, dates (created_at, updated_at) are defined within the model, this does not apply to the query.
The model should throw validation errors first!
Steps to Reproduce
class TestModel extends BaseModel
{
protected $table = 'table';
protected $allowedFields = [
'item_id', 'item_quantity'
];
protected $validationRules = [
'item_id' => 'required|is_natural_no_zero',
'item_quantity' => 'required|numeric',
];
protected $useSoftDeletes = true;
protected $protectFields = true;
protected $useTimestamps = true;
}
$model = new TestModel();
$model->upsert([
'item_id' => "string data", //validation is not correct
'item_quantity' => 99, //everything ok
'col1' => "string data", //not in allowed fields
]);
//check validation errors
$model->errors();
$model->db->getLastQuery()->getQuery();Expected Output
INSERT INTO `table` (`item_quantity`, `created_at`, `updated_at`)
VALUES (99, unix_timestamp, unix_timestamp)
ON DUPLICATE KEY UPDATE
`table`.`item_quantity` = VALUES(`item_quantity`),
`table`.`updated_at` = VALUES(`updated_at`)Anything else?
No response
Activity
kenjis commentedon Feb 20, 2023
What are the current outputs?
kenjis commentedon Feb 20, 2023
This is not a bug.
The model does not have the
upsert()method. So it is a Query Builder method.kenjis commentedon Feb 20, 2023
By the way, why do you need to use
upsert()in the Model?[-]Bug: Upsert problem with data validation, allowed fields, dates defined within the model.[/-][+]Bug: [Model] Upsert problem with data validation, allowed fields, dates defined[/+]maniaba commentedon Feb 21, 2023
When we need to save something, we use
insert(),update()orsave()(model methods). When we want to useinsert()orupdate()(upsert()), we don't have that method in the model. I understand that query builder and model are different classes and give different queries (example soft delete will not add in the query builder, but model will add, which is fine).I think it is necessary to have an
upsert()in the model.Otherwise, what is the purpose of having it only in the query builder?
maniaba commentedon Feb 21, 2023
Output for the
errors()methodreturns
null, should be a validation error for the item_id fieldOutput for the method
getQuery(),col1is not in allowed files and I get a database error for an unknown column, anditem_idis string, must be natural no zero.kenjis commentedon Feb 21, 2023
No, no. It was just added in Query Builder.
If you want to UPSERT, now you can use it with Query Builder.
As you know, not all Query Builder methods work with the Model.
If you really think the
upsert()should work with the Model,please make a feature request or send us a PR.
This is not a bug, just the current Model does not support the method.
[-]Bug: [Model] Upsert problem with data validation, allowed fields, dates defined[/-][+][Model] Upsert problem with data validation, allowed fields, dates defined[/+]