Skip to content

Login rate limiter should not count against successful logins #2647

Closed

Description

@jsjoeio

When running e2e tests against the login page, I'm hitting the login rate limit even though I'm using the correct password

image

Relevent code:
5accf3f

Activity

  1. added
    enhancementSome improvement that isn't a feature
    bugSomething isn't working
    and removed
    enhancementSome improvement that isn't a feature
    on Jan 28, 2021
  2. changed the title [-]Disable login rate limiter in dev/test mode[/-] [+]Login rate limiter should not count against successful logins[/+] on Jan 28, 2021
  3. sr229 commented on Jan 29, 2021

    @sr229
    Contributor

    this looks like the limiter couldn't distinguish from successful logins to non-successful logins. Will give this a look later.

  4. added this to the On Deck milestone on Apr 2, 2021
  5. modified the milestones: On Deck, v3.9.4 on Apr 15, 2021
  6. self-assigned this
    on Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions