Repository navigation
Fix cookie domain not using --proxy-domain - #8076
Open
RaphaelFakhri wants to merge 1 commit into
Open
RaphaelFakhri wants to merge 1 commit into
RaphaelFakhri wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8075
getCookieDomainis meant to set the session cookie on the highest level proxy domain so that one login covers code-server and every proxied port. Since #6225,--proxy-domainvalues are stored as patterns like{{port}}.example.com, andgetCookieDomaincompares the host against those patterns literally. The comparison never matches, so the cookie always falls back to the request host. For example, logging in on8080.example.comsetsDomain=8080.example.comand you have to log in again onexample.comand on other ports.This change takes the part of each pattern after the label that contains
{{port}}({{port}}.example.comandcode-{{port}}.example.comboth becomeexample.com). It skips patterns that contain{{host}}because they do not name a fixed domain. Hosts that do not match a proxy domain,localhost, and IP addresses behave as before.Testing
getCookieDomaintests totest/unit/node/http.test.ts. Without the source change, 2 of them fail (Received: "8080.example.com",Received: "test.example.com"). With it, the file passes (73 tests)../ci/dev/test-unit.sh --forceExit: 354 passed, 1 failed. The failure iscreateApp › should unlink a socket before listening on the socket, which expectsEACCESand fails when run as root. It fails the same way without this change.prettier --check,eslint, andtsc --noEmitpass.