Skip to content

There was an error when the code page could not be obtained #2

Open
Open
There was an error when the code page could not be obtained#2

Description

@wll8
wll8
opened on Jun 17, 2022

image

image

There was an error when the code page could not be obtained

Activity

  1. coderaiser commented on Jun 17, 2022

    @coderaiser
    coderaiser
    on Jun 17, 2022
    Owner

    I thinking about dropping support of such codepages, it worked on Windows XP which is no longer supported by newest node.js, but I don’t have Windows right now. What Windows are you use? Are you willing for a PR with a fix?

  2. wll8 commented on Jun 17, 2022

    @wll8
    wll8
    on Jun 17, 2022
    Author

    I am using win10. The question is, is cpcp437 a correct code page? or cp437 ?

  3. coderaiser commented on Jun 17, 2022

    @coderaiser
    coderaiser
    on Jun 17, 2022
    Owner

    I think cp437 is correct.

  4. wll8 commented on Jun 17, 2022

    @wll8
    wll8
    on Jun 17, 2022
    Author

    so? const CHCP = 'cp437'; => const CHCP = '437';

  5. coderaiser commented on Jun 17, 2022

    @coderaiser
    coderaiser
    on Jun 17, 2022
    Owner

    so? const CHCP = 'cp437'; => const CHCP = '437';

    Yes! And would be great to have a test for it, so bug never occur again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions