Repository navigation
Classify the rest of the titles; und.toml holds no title (#750) - #773
Merged
Merged
Conversation
The 644 titles still generic in und.toml take their kinds and leave for the files of the languages whose names they occur in: occupations, military ranks, offices and modifiers mostly to en.toml, dr, prof, docent and professor to mul.toml, the noble ranks and native-script academic and religious titles to their languages' files. Four files are new (bin, ff, mi, yi). The block comments over the native-script titles become notes on one entry of each group, and duke's keep-out becomes an exclusion in en.toml with its counts. No compiled set moves: build --check is current and the snapshot matches. Part of #750. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
clergyman records no gender, the list holding no clergywoman, so the data matches the -man rule the entry states; build.py's und.toml exemption quotes a pointer that still exists; the shared-readings bullet lists all eleven credentials. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #773 +/- ##
=======================================
Coverage 99.05% 99.05%
=======================================
Files 47 47
Lines 4642 4642
=======================================
Hits 4598 4598
Misses 44 44 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
wm keeps the generic title kind with a note saying it is William's abbreviation, made a title for #68; doctor joins dr, prof, docent and professor in mul.toml; पंडित and पं are academic, as part 1's refusal of the Latin pandit is keyed. The #9 court words carry issue = 9, expands keeping only their meaning; tsar and giani put their native spelling in native. Restored: #606's reason for administrator and commissioner, #344's native-only rule (on न्यायमूर्ति), डा's edge-period remark. Fixed: duke's example bearer, the д-р note's use of family-first, the README's refusal-only example (senior gained a reading), hon's and mpco-cg's notes, edmi's guess. Part 1's entry marks what part 2 completed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
wm's note and entry cite the parse removal moves, measured with the word removed: only the bare 'Wm Smith' depends on it, the dotted 'Wm.' being taken by the period-abbreviation shape rule either way. The README and the decisions entries say wm is the one generic title left. डा's edge-period remark is a note in hi.toml, not an expands in two files. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
--kind title names the whole title category, so the und.toml query counts the titles left there, not the generic ones; no query isolates the generic kind, and wm is the one left, in en.toml. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A claim about what a vocabulary entry does is measured on the parse without it; wm's first note read it off the parse with the word listed, and rules/H2's shape rule shadows the dotted spelling. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Classifies the 644 titles still generic in
nameparser/vocab/und.tomlinto the ten title kinds #769 added, and moves each into the files of the languages whose names it occurs in.und.tomlnow holds no title (uv run python tools/vocab/query.py --kind title --file und --countprints 0), which is #750's done-when. One word keeps the generic kind, in en.toml:wm, the abbreviation of William, made a title for #68. No title kind describes it, and removing it would move a parse (the bareWm Smith), so that is left to its own change.No compiled set moves.
tools/vocab/build.py --checkreports_compiled.pycurrent, andtools/differential/snapshot.pymatches the snapshot. The suite, mypy and ruff are green.What moved where
vice,rear,petty, the ordinals, the domain words such asbaseballandtax, and the court words from Judge-related titles not parsing #9's list of judges' titles).dr,prof,docent,doctor,professor.rabbito he,rebbeto yi,maharajah/maharani/subedarto hi,tsar/tsarinato ru,effendito tr.edohen,ekegbian), ff (lamido), mi (rangatira), yi (rebbe).lord,lady,knightandchiefarenobility, anddeputyis anoffice.Contested assignments (shown to Derek before opening, approved in chat 2026-10-19)
baron: en, fr, nl, desultan: ar, ms, trgreve: sv, da, nbд-р,проф,акад: ru, uk, bgm, askingalready is.-essform is marked (actress,heiress).sultanrecords none, because Ottoman usage gave it to imperial women too.academicas a form of address:advocate,attorney,engineer,nurse.ra,wp,pd/priv.-doz,dipl.-ing.me.पंडित/पं, matching part 1'sacademicrefusal of the Latinpandit.marquis25,041,royal24,394,deacon11,570,baron7,059, ...). This PR only classifies them; whether any should stop being a title is a separate change.Comments became fields
जीsuffix #344 block comments are notes on one entry of each group.duke's keep-out comment is anexcludedentry in en.toml, with its counts.und.toml's credential readings that shared an entry with a moved title sit in their own section, as Classify the particles in und.toml by language and kind #749's did.The record is the new 2026-10-19 entry in
docs/design/decisions/vocabulary-model.md. Review: the docs review found three small defects, fixed in the second commit and re-reviewed clean. The PR review (code reviewer and comment analyzer) found note, kind and doc defects, fixed in the third commit with Derek's calls onwm,doctorandपंडित. The review of that fix found three more (thewmparse claim, measured with the word listed rather than removed; two "all titles classified" statements;डा's remark inexpands), fixed in the fourth; the fifth corrects part 1's recompute sentence, since--kind titlecounts the whole category and no query isolates the generic kind. Each fix commit was reviewed. The sixth records thewmlesson as a field note indocs/design/mechanisms.md's Verification shapes: a claim about what a vocabulary entry does is measured on the parse without it (docs review clean).Closes #750.
🤖 Generated with Claude Code