Repository navigation
Read a bare Ing after a comma as an ambiguous credential (#848) - #858
Merged
Merged
Conversation
`Viera Sevcikova, Ing` gave given 'Ing', family 'Viera Sevcikova' on 1.4.0 through 2.5.0. Ing is the engineering degree of Czech, Slovak, Austrian and Romanian names, and a surname (Census 1,814), so it is marked ambiguous as PA is: `John Ing` and `HO, ING` keep their names. The accepted cost: `Ing.` after a comma moves from title to suffix too, while `Mgr.` and `MUDr.` stay titles, so `Martin Hulin, Ing., Mgr., PhD.` splits the pair. Given and family stay right in every moved name. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #858 +/- ##
=======================================
Coverage 99.05% 99.05%
=======================================
Files 47 47
Lines 4669 4669
=======================================
Hits 4625 4625
Misses 44 44 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
… the I.N.G. cost The design-docs review found the dotted `Ing.` stays a title after a one-word or empty head (`Novak, Ing.`), that the dotted initials `I.N.G.` now read as the credential with no report as `M.A.` does, that capitalized(force=True) now writes a capitals ING as 'Ing', and that the merged release bullet lists 37 credentials, not 36. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The second review found the stays-a-title list wrong for the capitals `ING.`, which leans to the credential as `MA.` does; the I.N.G. cost understated (`John I.N.G.` and `John Smith nee I.N.G.` lose a family or maiden name, as their M.A. twins already do); two pointers still saying "after a comma" unscoped; and "capitalized() moves no name's rendering" false where a role move reorders it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #848.
What changes.
Ing, the engineering degree of Czech, Slovak, Austrian and Romanian names, is now a credential marked ambiguous, asPAis (#797). Before this, the comma read the unlisted word as the given name.Viera Sevcikova, IngIng, familyViera SevcikovaViera, familySevcikova, suffixIngJohn IngIngIng(fork reported)HO, INGING, familyHOFilip Polák, Ing.Ing.Ing.Martin Hulin, Ing., Mgr., PhD.Ing. Mgr., suffixPhD.Mgr., suffixIng., PhD.Why ambiguous, not plain.
Ingis a surname (US Census 1,814, over the 200-bearer threshold) and a Swedish given name. It stays out of the titles (#840), since a title would claimIng Smith.Accepted costs.
Ing.moves from title to suffix with the bare form, whileMgr.,MUDr.,Bc.andDipl.-Ing.stay titles. Czech writes all of them before the name, so a comma-separated list holding two of them is split across fields. Given and family stay right in every such name. KeepingIng.a title would take a new rule for one word. Written in Title case, after a one-word or empty head (Novak, Ing.,, Ing.) or with no comma between it and another title (Jan Novak, Ing. Mgr.), it stays a title and now reports the fork. Written in capitals in a mixed-case name,ING.leans to the credential asMA.andPA.do, soNovak, ING.gives suffixING..I.N.G.read as the credential with no report, asM.A.already does, so a name spelled in them is lost where they stand last:Smith, I.N.G.loses its given name,John I.N.G.its family name, andJohn Smith nee I.N.G.its maiden name. TheM.A.twins of each read that way on master.Out of scope.
Jana Bartáková, Ing et PhD(a connective inside the credential run) andJiří Cihlář, Prof Ing(a credential behind a title) read as before.Case. A
cased = "Ing"mask makescapitalized()writeIng, notING. That is also the surname's own title case, socapitalized()recases no word differently (a word moved between fields still moves the rendering's order).capitalized(force=True)now writes a capitals credential asIngtoo (John Smith, ING→John Smith Ing, where it keptING).Measured (2026-10-23, against 332f24a, local corpora recorded from the base tree first):
ctgov-officials: 22 of 352,104 readings move. 7 names stop reversing, 10 dotted names moveIng.from title to suffix with given and family unchanged, and 5 only gain thesuffix-or-namereport (Jeffrey J Ing, MDkeeps familyIng).fec-individuals1,psc-individuals13,tse-donors0, each only gaining the report.Ingafter a comma, sosnapshot.jsonldoes not move.Decisions:
decisions/suffix-acronym-collisions(Standing bullet and a 2026-10-23 log entry).decisions/salutation-titlesdrops its open pointer to #848. Release log: folded into the #797 bullet.🤖 Generated with Claude Code