Skip to content

Read a bare Ing after a comma as an ambiguous credential (#848) - #858

Merged
derek73 merged 4 commits into
masterfrom
fix/issue-848-ing-credential
Oct 24, 2026
Merged

derek73 merged 4 commits into
masterfrom
fix/issue-848-ing-credential

Conversation

@derek73

@derek73 derek73 commented Oct 24, 2026 •

Copy link
Copy Markdown
Owner

Closes #848.

What changes. Ing, the engineering degree of Czech, Slovak, Austrian and Romanian names, is now a credential marked ambiguous, as PA is (#797). Before this, the comma read the unlisted word as the given name.

Input 2.5.0 now
Viera Sevcikova, Ing given Ing, family Viera Sevcikova given Viera, family Sevcikova, suffix Ing
John Ing family Ing family Ing (fork reported)
HO, ING given ING, family HO same (fork reported)
Filip Polák, Ing. title Ing. suffix Ing.
Martin Hulin, Ing., Mgr., PhD. title Ing. Mgr., suffix PhD. title Mgr., suffix Ing., PhD.

Why ambiguous, not plain. Ing is a surname (US Census 1,814, over the 200-bearer threshold) and a Swedish given name. It stays out of the titles (#840), since a title would claim Ing Smith.

Accepted costs.

  • After a full name and a comma, the dotted Ing. moves from title to suffix with the bare form, while Mgr., MUDr., Bc. and Dipl.-Ing. stay titles. Czech writes all of them before the name, so a comma-separated list holding two of them is split across fields. Given and family stay right in every such name. Keeping Ing. a title would take a new rule for one word. Written in Title case, after a one-word or empty head (Novak, Ing., , Ing.) or with no comma between it and another title (Jan Novak, Ing. Mgr.), it stays a title and now reports the fork. Written in capitals in a mixed-case name, ING. leans to the credential as MA. and PA. do, so Novak, ING. gives suffix ING..
  • The dotted initials I.N.G. read as the credential with no report, as M.A. already does, so a name spelled in them is lost where they stand last: Smith, I.N.G. loses its given name, John I.N.G. its family name, and John Smith nee I.N.G. its maiden name. The M.A. twins of each read that way on master.

Out of scope. Jana Bartáková, Ing et PhD (a connective inside the credential run) and Jiří Cihlář, Prof Ing (a credential behind a title) read as before.

Case. A cased = "Ing" mask makes capitalized() write Ing, not ING. That is also the surname's own title case, so capitalized() recases no word differently (a word moved between fields still moves the rendering's order). capitalized(force=True) now writes a capitals credential as Ing too (John Smith, ING → John Smith Ing, where it kept ING).

Measured (2026-10-23, against 332f24a, local corpora recorded from the base tree first):

  • ctgov-officials: 22 of 352,104 readings move. 7 names stop reversing, 10 dotted names move Ing. from title to suffix with given and family unchanged, and 5 only gain the suffix-or-name report (Jeffrey J Ing, MD keeps family Ing).
  • fec-individuals 1, psc-individuals 13, tse-donors 0, each only gaining the report.
  • The committed corpora hold no Ing after a comma, so snapshot.jsonl does not move.

Decisions: decisions/suffix-acronym-collisions (Standing bullet and a 2026-10-23 log entry). decisions/salutation-titles drops its open pointer to #848. Release log: folded into the #797 bullet.

🤖 Generated with Claude Code

`Viera Sevcikova, Ing` gave given 'Ing', family 'Viera Sevcikova' on
1.4.0 through 2.5.0. Ing is the engineering degree of Czech, Slovak,
Austrian and Romanian names, and a surname (Census 1,814), so it is
marked ambiguous as PA is: `John Ing` and `HO, ING` keep their names.

The accepted cost: `Ing.` after a comma moves from title to suffix
too, while `Mgr.` and `MUDr.` stay titles, so `Martin Hulin, Ing.,
Mgr., PhD.` splits the pair. Given and family stay right in every
moved name.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@derek73 derek73 added this to the 2.6 milestone Oct 24, 2026
@derek73 derek73 added bug vocabulary Per-word vocabulary model and language packs labels Oct 24, 2026
@derek73 derek73 self-assigned this Oct 24, 2026
@codecov

codecov Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.05%. Comparing base (332f24a) to head (759cd18).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #858   +/-   ##
=======================================
  Coverage   99.05%   99.05%           
=======================================
  Files          47       47           
  Lines        4669     4669           
=======================================
  Hits         4625     4625           
  Misses         44       44           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

derek73 and others added 3 commits October 23, 2026 20:10
… the I.N.G. cost

The design-docs review found the dotted `Ing.` stays a title after a
one-word or empty head (`Novak, Ing.`), that the dotted initials
`I.N.G.` now read as the credential with no report as `M.A.` does,
that capitalized(force=True) now writes a capitals ING as 'Ing', and
that the merged release bullet lists 37 credentials, not 36.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The second review found the stays-a-title list wrong for the capitals
`ING.`, which leans to the credential as `MA.` does; the I.N.G. cost
understated (`John I.N.G.` and `John Smith nee I.N.G.` lose a family
or maiden name, as their M.A. twins already do); two pointers still
saying "after a comma" unscoped; and "capitalized() moves no name's
rendering" false where a role move reorders it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@derek73
derek73 merged commit de32587 into master Oct 24, 2026
10 checks passed
@derek73
derek73 deleted the fix/issue-848-ing-credential branch October 24, 2026 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug vocabulary Per-word vocabulary model and language packs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Should a bare Ing after a comma be a credential? Viera Sevcikova, Ing reads given Ing, family Viera Sevcikova

1 participant