Repository navigation
Read a bare Wm as the given name it abbreviates, not a title (#789) - #873
Merged
Merged
Conversation
`wm` was listed as a title for #68, which asked that `Wm. Scott Magargee III` not read given name `Wm.`. Wm is William written short, so the request was mistaken; on 08d130e bare WM opened the given part of 69 FEC donor names, every one read as a title. The title reading is refused in en.toml with that reason. The dotted Wm. opening the given part is still rules/H2's title; a given reading that outranks H2 is phase 2's (#752). Where vocabulary read it (a trailing Wm., H5; a Wm. before a family comma, H6) it is a name word again, as in 1.4.0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ve the dotted half open (#789 review) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #873 +/- ##
=======================================
Coverage 99.07% 99.07%
=======================================
Files 47 47
Lines 4735 4735
=======================================
Hits 4691 4691
Misses 44 44 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Takes bare
wm(William) out of the default titles, soWm Smithreads givenWm, lastSmith. 1.4.0 through 2.5.0 read titleWmwith no given name. This is part (a) of #789. Part (b), the dottedWm., stays open for phase 2 (#752).wmwas listed as a title in 0.5.5 for #68, which asked thatWm. Scott Magargee IIInot read given nameWm.. That request was mistaken: Wm is William written short. The title reading is now anexcluded = { title = … }entry innameparser/vocab/en.tomlthat carries the reason, so anyone who adds it back hits the reason as a build error (query.py --word wm,--issue 789).What moves
Wm SmithWm, lastSmithWm, lastSmithWm Scott SmithWm, firstScottWm, middleScottDr. Wm SmithDr. WmDr., firstWmWm. SmithWm.Wm.(unchanged, rules/H2)John Smith Wm.Wm.Wm.(1.4.0 through 2.2.0's reading)Smith, John Wm.Wm.Wm.(1.4.0 through 2.2.0's reading)Wm. Smith, JohnWm.Wm. Smith(1.4.0 through 2.4.0's reading)Out of scope: the dotted
Wm.opening the given part. rules/H2 (the leading-abbreviation title) reads any unlisted period-marked abbreviation there as a title, whether or not the word is listed. MakingWm.,Chas.,Geo.,Ma.orJo.a given name in that slot needs a reading that outranks a shape rule. That is phase 2's D14(b), not this PR.tests/v2/cases.pypins today'sWm. Smithso the phase 2 change shows up there. #789 stays open for that half (this PR does not close it), and it is on decisions/vocabulary-model's Open: line.A correction this PR makes. The 2026-10-19 decisions entry, and #789's body, both say removing
wmmoves only the bare spelling. That was wrong on its date. It took the off-switch parse at the head of the name only. A trailingWm.(rules/H5, the trailing title run) and aWm.before a family comma (rules/H6, the title before a family comma) are read by vocabulary, not shape, so they move too. The entry is corrected in place, and the mechanisms.md field note now says to take the off-switch parse in each position as well as each spelling.Measured
Base is 08d130e. Local snapshots were recorded with
--treeon a master checkout.wm, so these could not move.WMopens the given part.WMbehind another title.WM..WM.before the family comma.Wmbehind a title, before a family comma.local_agreement.py): matches the record.Docs
Chas. Smithread givenChas.? Abbreviated given names read as titles today #789 entry, a Standing line, and ShouldChas. Smithread givenChas.? Abbreviated given names read as titles today #789 on the Open: line. The 2026-10-19 Classify the titles in und.toml by language and kind #750 bullet is marked superseded and its measurement corrected in place.wmadded to the TITLES refusal list.wmexception sentence is removed.Mr Sultan Khan,Mr Md Karim Uddin)? #853 and Read a semicolon between post-nominals as a comma (D15) #871.Wm Smithbelongs in that list.Checks
uv run pytestand-n0 -m serial: pass.uv run --python 3.15 pytest: pass.mypyandruff check: clean.sphinx-build -b doctest docs: 0 failures.🤖 Generated with Claude Code