Skip to content

fix(windows): prevent console windows at every Core child-process boundary - #9

Open
ellmos-multi-bot wants to merge 1 commit into
mainfrom
multibot/fix-windowless-processes-2071-20261022
Open

ellmos-multi-bot wants to merge 1 commit into
mainfrom
multibot/fix-windowless-processes-2071-20261022

Conversation

@ellmos-multi-bot

Copy link
Copy Markdown
Collaborator

Windows background bot actions could open console windows because seven direct gh/git/ssh-keygen starts did not set CREATE_NO_WINDOW. A hidden Python parent does not automatically hide its console children.

This sets the Windows flag at all seven production boundaries, using zero on other platforms, and also protects the six direct subprocess starts in the existing tests. The standalone review-gate verifier remains standalone; credential, permission, preview/apply, signature and exact-head checks are unchanged. No version bump or installation is included.

Validation: two parametrized Windows/POSIX regression cases passed; they exercise all seven production adapters using fake runners and launch no real child processes. Ruff passed for the nine Python files, and git diff --check passed. An independent source review approved the exact ten-file content (SHA-256 acc3ab14bbef1a8209295740ac51b28e977079c41fa7b58ba6a590550957a60f) without open findings. Full hosted CI and independent merge review remain required.

Related operational scope: BACH #2071 and the explicit user request to prevent recurring console-window storms. The installed companion is not changed by this PR.

Generated-with: Codex; session 01a164da-cc28-7140-b499-d40dae7c2e11

Generated-with: Codex; session 01a164da-cc28-7140-b499-d40dae7c2e11
@ellmos-multi-bot

Copy link
Copy Markdown
Collaborator Author

Independent review - head a0730afc049987339ec0e1594f07a8bc42735cba

Finding (P2): tests/test_consumer_install.py:152 starts cmd.exe with a direct subprocess.Popen call that does not set creationflags=subprocess.CREATE_NO_WINDOW. The opt-in consumer-install test therefore still opens a console window on Windows; this launch is separate from the _run() helper hardened by this PR. Please pass the guarded Windows creation flag on this process start as well.

The current GitHub CI checks test (3.10) and test (3.12) both pass for this head. git diff --check passes. I did not run local tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant