Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
|
👁️🗨️ Review this pull request with grouped, summarized diffs at: raw result💭 analyzed by {
"headSha": "0ab29476ab699af58189f21985ce0c1738b630d9",
"result": {
"overallSummary": "Fixes a UX bug in the Inspector Functions tab where invalid JSON arguments failed silently: an inline error is now shown via `FeedbackTip`, cleared on input change, and invalid input no longer triggers an RPC call or hides a prior successful result. Storybook interaction tests cover the new behavior.",
"groups": [
{
"key": "inspect-arg-parse-error",
"label": "Inspector argument parse error",
"summary": "Shows an inline `FeedbackTip` error when JSON argument parsing fails in the Inspector Functions tab, instead of silently doing nothing. The error clears as soon as the input changes, and a failed invoke no longer dispatches an RPC or overwrites a previous successful result.",
"category": "ui",
"filePaths": [
"plugins/inspect/app/components/FunctionRow.vue",
"plugins/inspect/app/components/FunctionsView.vue"
],
"fileNotes": [
{
"path": "plugins/inspect/app/components/FunctionsView.vue",
"text": "Previously `invoke` threw on bad JSON (uncaught); now it stores a per-function error message and returns early instead of emitting `invoke`."
}
]
},
{
"key": "stories",
"label": "Storybook interaction tests",
"summary": "Adds Storybook play-function tests covering invalid input, recovery after fixing the input, and invalid input entered after a prior successful call.",
"category": "tests",
"filePaths": [
"plugins/inspect/app/components/FunctionsView.stories.ts"
]
}
],
"schemaVersion": 1,
"source": "llm",
"generatedAt": "2026-10-21T14:13:19.490Z",
"model": "vercel-ai-gateway/anthropic/claude-sonnet-5",
"locale": "en"
}
} |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In the Inspector's Functions tab, malformed JSON makes Invoke fail without a visible error. After a successful call, the previous green result remains without feedback about the failed attempt.
Display the parsing error below the arguments input and clear it when the input changes. Keep the previous result visible alongside the current error.
Evidence
{and click Invoke. No error appears, and any previous successful result remains.After: The panel shows
Invalid JSON arguments: …alongside the previous result. Editing clears the error, and corrected arguments invoke successfully.pnpm lint,pnpm knip,pnpm test,pnpm typecheck, andpnpm build. Tests: 1755 passed, 13 skipped.Merge Danger
Door: two-way
The change can be reverted without a data migration or public API change.
Blast Radius: Inspector
The shared
FunctionRowgains an optional error prop. Functions supplies it; Client keeps its existing behavior. Argument coercion, RPC result handling, and invocation restrictions remain unchanged.