Repository navigation
fix: round timeouts up and saturate them, so only zero waits without limit - #440
Merged
Merged
Conversation
…limit A positive timeout under the unit it is waited in came out as zero, which HttpURLConnection and the media reader take as no limit, and one too long to count failed or also came out as zero. Timeouts now converts every timeout in one place, and the native reader saturates its deadline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A positive timeout shorter than the unit it is waited in became zero, which
HttpURLConnectionand the media reader take as no limit; one too long to count threw later or became zero as well.Timeoutsnow checks and converts every timeout of the client API and the media reader in one place: rounded up, saturated, and only a given zero means no limit. The native reader saturates its deadline too.