Repository navigation
fix(performance): Parquet benchmark reads nullable taxi columns through the mask - #501
Merged
Merged
Conversation
…gh the mask vortexRead/vortexReadMultiColumn cast c.column(...) straight to DoubleArray / IntArray and crashed with ClassCastException once nullable global-dict columns began decoding to a MaskedArray (null as an invalid dictionary entry, as Rust writes it, #467/#468). Fold the values under the mask, as the Parquet batch path folds its arrays. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015R8cf8YM8XFQqrkyhSAtYr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vortexReadandvortexReadMultiColumncastc.column(...)straight toDoubleArray/IntArray. They crashed with aClassCastExceptiononce nullable global-dictionary columns began decoding to aMaskedArray(null stored as an invalid dictionary entry, as Rust writes it, #467/#468). They now fold the values under the mask, as the Parquet batch path folds its arrays.This change is benchmark-only and has no CHANGELOG entry. A local smoke run gives
vortexReadabout 268 andvortexReadMultiColumnabout 130 ops/s again.🤖 Generated with Claude Code
https://claude.ai/code/session_015R8cf8YM8XFQqrkyhSAtYr