Repository navigation
refactor(writer): name the OnPair scan counter's method apart from its field - #585
Merged
Merged
Conversation
…s field Sonar java:S1845 (blocker severity): Threshold had both a field and a method named scanned. The method, which counts bytes and reports the exhausted budget, is now scan. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the only blocker-severity issue on
mainbefore 0.18.0: Sonarjava:S1845inOnPairEncodingEncoder. Its privateThresholdclass had both a field and a method namedscanned. The method, which counts scanned bytes and reports when the budget is used up, is nowscan.The rename is private, so behavior is unchanged; the OnPair tests pass.
🤖 Generated with Claude Code