Joint Segmentator Doesn't Calculate correctly the total amount of joints

For this assembly, it was trying to find 4 joints. Switching from i_assembly.total_number_joints to len(i_assembly._all_joints) did the trick

@eleniv3d

Hello @eleniv3d , I belive that you might running on a branch not updated with the current main. In the main the DFAssembly.total_number_joints does not exists:

diffCheck/src/gh/diffCheck/diffCheck/df_geometries.py

Lines 403 to 423 in f205939

    
           class DFAssembly: 
        
               """ 
        
               This class represents an assembly of beams 
        
               """ 
        
               beams: typing.List[DFBeam] 
        
               name: str 
        
               def __post_init__(self): 
        
                   self.beams = self.beams 
        
                   for idx, beam in enumerate(self.beams): 
        
                       beam._index_assembly = idx 
        
                   self.__uuid = uuid.uuid4().int 
        
                   self.name = self.name or "Unnamed Assembly" 
        
                   self._all_jointfaces: typing.List[DFFace] = [] 
        
                   self._all_sidefaces: typing.List[DFFace] = [] 
        
                   self._all_vertices: typing.List[DFVertex] = [] 
        
                   self._all_joints: typing.List[DFJoint] = []

Nevertheless, the way you are doing it is the correct one.

@9and3

I believe it is like that on the main :) @9and3

https://github.com/diffCheckOrg/diffCheck/blob/main/src/gh/components/DF_joint_segmentator/code.py

@eleniv3d

Apologies @eleniv3d I didn't get you are referring to the DFJointSegmentator. Acutally we do have a property in DFAssembly (my bad sorry again):

@property
    def total_number_joints(self):
        return max([joint.id for joint in self.all_joints]) + 1

In your scenario how many joints do you obtain (wrongly)?

@DamienGilliard

we discussed with @DamienGilliard , he's a bit busy at the moment but since it's touching the segmentation Python component he will take care of solving this. Thanks for bringing this up @eleniv3d 👐

@DamienGilliard

@DamienGilliard / @eleniv3d , do you know the status on this one?

@9and3

@9and3 , @eleniv3d , it is still on my desk. The workaround of Eleni works fine I believe, but this must be fixed. I have planned to work on diffcheck this afternoon, I'll try to get it fixed then.

Great, let me know, you can link this issue to the PR you are opening so we know is tracked ! 👐

Navigation Menu

Repository navigation

Joint Segmentator Doesn't Calculate correctly the total amount of joints #120

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	class DFAssembly:
	"""
	This class represents an assembly of beams
	"""

	beams: typing.List[DFBeam]
	name: str

	def __post_init__(self):
	self.beams = self.beams
	for idx, beam in enumerate(self.beams):
	beam._index_assembly = idx

	self.__uuid = uuid.uuid4().int

	self.name = self.name or "Unnamed Assembly"

	self._all_jointfaces: typing.List[DFFace] = []
	self._all_sidefaces: typing.List[DFFace] = []
	self._all_vertices: typing.List[DFVertex] = []
	self._all_joints: typing.List[DFJoint] = []

Joint Segmentator Doesn't Calculate correctly the total amount of joints #120

Description

Activity

9and3 commented on Sep 24, 2024

eleniv3d commented on Sep 24, 2024

9and3 commented on Sep 24, 2024

9and3 commented on Sep 25, 2024

9and3 commented on Sep 30, 2024

DamienGilliard commented on Sep 30, 2024

9and3 commented on Sep 30, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions