Repository navigation
XML Extension - #293
Merged
Merged
XML Extension#293
Conversation
Integrated WTP XML formatter. Fixed WTP formatter step naming (WtpEclipse -> EclipseWtp). Naming convention for all Eclipse formatter is Eclipse<Kind>...
fvgh
added a commit
that referenced
this pull request
Sep 4, 2018
The Eclipse formatter is described in a dedicated sub-section. The configFile example follows directly after the describing paragraph.
fvgh
added a commit
that referenced
this pull request
Sep 4, 2018
nedtwigg
approved these changes
Sep 4, 2018
nedtwigg
left a comment
Member
There was a problem hiding this comment.
Everything looks great except the default includes, but in the end I think they're sensible too. Having those defaults will probably help a few users get started, and won't hurt pro users anyway, so you won me over on them :)
Member
Author
|
@lutovich I would appreciate if you have a quick look on the Maven integration. |
thc202
reviewed
Sep 4, 2018
|
|
||
| } | ||
|
|
||
| /** If the user hasn't specified the files yet, we'll assume he/she means all of the C/C++ files. */ |
Merged
Prefer to remove the description. Code is simple enough.
thc202
reviewed
Sep 4, 2018
Member
|
This is awesome!!! |
Member
Author
|
@JLLeitschuh Just found some mistakes in the README.md. But before release I also want a problem with the Provisioner in the |
# Conflicts: # plugin-gradle/CHANGES.md # plugin-gradle/README.md # plugin-gradle/src/main/java/com/diffplug/gradle/spotless/SpotlessExtension.java # plugin-maven/CHANGES.md # plugin-maven/src/main/java/com/diffplug/spotless/maven/AbstractSpotlessMojo.java # plugin-maven/src/test/java/com/diffplug/spotless/maven/MavenIntegrationTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provided XML extension for Gradle and Maven.
Integrated Eclipse-WTP XML formatter step.
This PR implements #140 .
I took the liberty already to apply the formatter on Spotless itself. Hence the huge amount of changes.
Please follow the single commits for a better overview of the subjects addressed by the changes.