Repository navigation
Remember playback position and order across browser-source reloads - #11
Open
orangeqoon wants to merge 1 commit into
Open
orangeqoon wants to merge 1 commit into
orangeqoon wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reloading a browser source currently loses its position and, in random mode, reshuffles the slideshow before the previous loop has finished. With large image collections, this makes it harder to show the remaining images across OBS sessions.
This adds playback history to the existing HTML/JavaScript player, enabled by default. It stores the current image position and complete playback order in browser local storage, scoped to the full page URL, and restores both on reload. Users can opt out with
rememberPlayback = falseinsettings.jsor the new Remember playback position and order checkbox in the Lua settings. Older settings files also use the enabled default.Behavior and compatibility:
Validation:
node --test tests/playback-history.test.cjs: 19 passing tests, covering all ordering modes, enabled defaults, opt-out, older settings files, navigation, restart, changed lists/modes/URLs, invalid stored data, blocked/full storage, empty/single-image lists, captions, and autoplay behavior.git diff --checkpasses.The Lua checkbox/default/output wiring is included, but the new checkbox has not been exercised interactively inside OBS. The browser checks above used Chromium/Edge with a local HTTP fixture.