You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As far as I know almost always coverage is used to see "test coverage".
For unused branches/variables etc there are linters, dead-code finders (such as vulture or dead).
So I don't think code coverage is important to extent of running run_all.sh script.
I would like to
remove run_all.sh
collect coverage
only for tests
only for one python branch (e.g. 3.7) (although it is possible to do coverage run -p and then coverage combine)
I think that the basic idea was to able to run all scripts with one command. Coverage came later. So if we can simplify it by removing the coverage part since it's handled elsewhere, fine by me.
Activity
faif commentedon Feb 8, 2019
What's the reasoning behind running it only for a specific Python version (e.g. 3.7)?
gyermolenko commentedon Feb 8, 2019
a bit simpler, I guess. But combining is possible, so nevermind.
My biggest concern here is - why run_all.sh at all?
faif commentedon Feb 9, 2019
I think that the basic idea was to able to run all scripts with one command. Coverage came later. So if we can simplify it by removing the coverage part since it's handled elsewhere, fine by me.
gyermolenko commentedon Jan 14, 2020
To update on this issue:
run_all.shwas removedSo only some simplifications in
tox.iniare required to resolve the issue.