Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatic Handling missing values in PSI is important for me.
I offer the PR below - mostly AI generated and human reviewed.
Closes #883. Adds opt-in missing_values='include' to measure missingness drift
without merging missing observations into real-value bins. Numeric boundaries are
learned from observed basis values; all rows enter the frequency denominator.
Existing raise and ignore behaviour is preserved.
Proposed edge-case policy: with fewer than two distinct observed basis values,
compare a missing bin with a single observed bin rather than learn boundaries
from the test partition. Automatic thresholds count the populated bins, including
missingness. This policy remains open to maintainer feedback.
Validation: 77 focused tests pass on pandas 3.0/sklearn 1.9 and pandas 2.2/sklearn 1.4.
Tests include hand-calculated PSI, all-missing partitions, automatic thresholds,
duplicate row labels and category-name collisions. User guide and API docs updated;
type and style checks pass.
Dependency requirements are unchanged. Testing covers the two configurations above, not the full supported-version matrix.